Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sync E2E tests #3486

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix Sync E2E tests #3486

merged 1 commit into from
Oct 31, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Oct 31, 2024

Task/Issue URL: https://app.asana.com/0/1201037661562251/1208665937532326/f

Description:
Revert bookmark title to "Privacy, simplified".

Steps to test this PR:
Verify that this workflow is green

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ayoy ayoy merged commit 49ff187 into main Oct 31, 2024
24 checks passed
@ayoy ayoy deleted the dominik/fix-sync-e2e-tests branch October 31, 2024 13:58
samsymons added a commit that referenced this pull request Nov 4, 2024
# By Dax the Duck (5) and others
# Via GitHub (4) and Michal Smaga (1)
* main: (24 commits)
  Validate VPN errors before re-throwing them (#3490)
  Allowing users to delete suggestions (#3430)
  Bump version to 1.112.0 (296)
  Marking latest Bitwarden versions as incompatible (#3492)
  Bump version to 1.112.0 (295)
  Update to subscription cookie (#3489)
  Bug Fix: Phishing Detection Dataset Discrepancies (#3440)
  Bump version to 1.112.0 (294)
  Fix crash when opening permission popover for NewTab page address bar (#3484)
  Set version_check_wait_retry_limit to 1 (#3488)
  Refactor automatic update flow to use custom Sparkle user driver (#3274)
  Add to Dock - Update BSK version (#3479)
  Freemium PIR: Manual Removal Links (#3466)
  Fix Sync E2E tests (#3486)
  Fix crash on empty bookmarks html root element (#3482)
  update UI test (#3469)
  Update BSK with autofill 15.1.0 (#3480)
  Bump version to 1.112.0 (293)
  New tagline (#3401)
  add system info to webkit termination validation (#3473)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants