Enforce stricter hasPendingUpdate check #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @quanganhdo and the rest of your teammates on |
tomasstrba
approved these changes
Nov 13, 2024
| @@ -71,7 +71,7 @@ final class UpdateController: NSObject, UpdateControllerProtocol { | |||
| didSet { | |||
| if let cachedUpdateResult { | |||
| latestUpdate = Update(appcastItem: cachedUpdateResult.item, isInstalled: cachedUpdateResult.isInstalled) | |||
| hasPendingUpdate = latestUpdate?.isInstalled == false && updateProgress.isIdle | |||
| hasPendingUpdate = latestUpdate?.isInstalled == false && updateProgress.isDone && userDriver?.isResumable == true | |||
There was a problem hiding this comment.
Just optional: It would help with readability if this is wrapped up to a computed property and documented.
quanganhdo
force-pushed
the
anh/11-12-enforce_stricter_haspendingupdate_check
branch
from
a11d344 to
b89d4e3
Compare
quanganhdo
deleted the
anh/11-12-enforce_stricter_haspendingupdate_check
branch
samsymons
added a commit
that referenced
this pull request
Nov 14, 2024
# By Graeme Arthur (2) and others # Via GitHub * main: Disable reordering when sort by name is enabled (#3552) Move FE Overlay Pixel to the Native layer (#3550) Bump version to 1.114.0 (307) bump bsk for text zoom feature definition (#3496) Add support for local overrides for feature flags (#3545) Speculative password import prompt crash fix (#3542) Send error with fetch device failure pixel (#3546) DuckPlayer Overlay Pixels (#3538) Bump version to 1.114.0 (306) Enforce stricter hasPendingUpdate check (#3541) Implement Fire Window UI tests (#3544) Add cohort assignment pixel for NTP Search Box Experiment (#3539) Prevent Freemium PIR Pixel Firing for All Users (#3543) # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208746324713624/f
Tech Design URL:
CC:
Description:
Fixes Install Now menu item does nothing by making sure we can resume the update process. As a bonus, this fixes an edge case where the user toggles back and forth between automatic & manual update checkboxes and that causes the upgrade process to go weird.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation