Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translations to new permissions strings #3548

Merged

Conversation

jotaemepereira
Copy link
Collaborator

@jotaemepereira jotaemepereira commented Nov 14, 2024

Task/Issue URL: https://app.asana.com/0/38424471409662/1208755378695455/f
Tech Design URL:
CC:

Description:
Add missing translations to new permissions strings

Steps to test this PR:

  1. Open different permissions (camera and location) in different languages
  2. Check that they are correctly translated

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@jotaemepereira jotaemepereira requested a review from ayoy November 14, 2024 00:34
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jotaemepereira jotaemepereira merged commit a798df5 into release/1.114.0 Nov 14, 2024
31 of 33 checks passed
@jotaemepereira jotaemepereira deleted the juan/add-translations-to-permissions branch November 14, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants