Show error message inside downloads popup when download fails because OS issue #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
force-pushed
the
juan/possible-fix-downloads
branch
2 times, most recently
from
32b064f to
25b7cb9
Compare
|
ayoy
reviewed
Nov 21, 2024
There was a problem hiding this comment.
@jotaemepereira thanks for this fix! It works well for me (I had to comment out a few more assert calls) and I only have an autolayout issue when there are more downloads on the list:
Hopefully it's a simple fix.
jotaemepereira
force-pushed
the
juan/possible-fix-downloads
branch
from
25b7cb9 to
da11f6e
Compare
|
@ayoy Thanks for the feedback! The constraints issue should be fixed:
|
jotaemepereira
force-pushed
the
juan/possible-fix-downloads
branch
from
7981942 to
7ec6797
Compare
ayoy
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204006570077678/1208780258680374/f
Tech Design URL:
CC:
Description:
AC1
Given a user on macOS 14.7.1
When the user fails to download a fail with error code 256 and type NSFileReadUnknownError
Then we show an error banner with some guidance on how to update
AC2
Given a user on macOS 15.0.1
When the user fails to download a fail with error code 256 and type NSFileReadUnknownError
Then we show an error banner with some guidance on how to update
Notes:
How To Updatebutton that will take the user to this page: https://support.apple.com/guide/mac-help/get-macos-updates-and-apps-mh35618/macFor Sparkle users: We will show a
Open Settingsbutton that it will take them to System Settings → Software UpdateSteps to test this PR:
To test this, you first need to mimic the error. To force this, go to
WebKitDownloadTask, and after line 330, throw the following exception:Then, if you are not on macOS 14.7.1 or 15.0.1, you need to add your current OS to the
isSpecificMacOSVersionfunction in theDownloadListViewModel.If you want to test Sandbox vs Non-sandbox, you can change how the view is initialized in the
DownloadsViewControllerline 140.Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation