Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove malformed error pixel #3612

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Conversation

samsymons
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/414235014887631/1208683003138954/f
Tech Design URL:
CC:

Description:

This PR removes the malformed error pixel.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Check that CI is green and that the pixel is correctly removed

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

samsymons added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Nov 30, 2024
Required:

Task/Issue URL: https://app.asana.com/0/414235014887631/1208683003138954/f
iOS PR: duckduckgo/iOS#3647
macOS PR: duckduckgo/macos-browser#3612
What kind of version bump will this require?: Major

Description:

This PR removes the malformed error event, as it was temporary.
# By Anka (2) and others
# Via GitHub (2) and Michal Smaga (1)
* main:
  Add support for RMF survey `locale` parameter (#3613)
  Revert to empty RMF config for debug builds (#3616)
  Fix test
  Display Privacy Stats on HTML New Tab Page (#3611)
  point to BSK branch and updates (#3606)
  Bump version to 1.116.0 (319)
  Client displays correct subscription (#3581)
  Bump version to 1.116.0 (318)
  [Release PR] Add StoreKit debugging menu options (#3607)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons samsymons merged commit 38e5181 into main Nov 30, 2024
21 checks passed
@samsymons samsymons deleted the sam/remove-malformed-error-pixel branch November 30, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants