Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for schedulingConfig decoding issue #3624

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

quanganhdo
Copy link
Member

Task/Issue URL: https://app.asana.com/0/0/1208895860990675/f
Tech Design URL:
CC:

Description:

This fixes an error with JSON decoding preventing PIR to save profile.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Test PIR on a fresh install
  2. Test PIR on macOS 1.115.0 upgrading to this version

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also tested from a clean slate and it also worked

@quanganhdo quanganhdo changed the base branch from main to hotfix/1.116.1 December 3, 2024 17:52
@quanganhdo quanganhdo merged commit 81ba2ef into hotfix/1.116.1 Dec 3, 2024
30 of 34 checks passed
@quanganhdo quanganhdo deleted the anh/fixes/scheduling-config-hardcode branch December 3, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants