Add Missing Enum to Freemium RMF Implementation #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aataraxiaa
force-pushed
the
pete/complete-freemium-RMF-implementation
branch
from
712dfa1 to
5c7c50f
Compare
samsymons
approved these changes
Dec 5, 2024
aataraxiaa
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 5, 2024
**Required**: Task/Issue URL: https://app.asana.com/0/1206488453854252/1208904081551825/f iOS PR: duckduckgo/iOS#3673 macOS PR: duckduckgo/macos-browser#3631 What kind of version bump will this require?: Patch **Description**: Adding missing Freemium RMF enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206488453854252/1208904081551825/f
Description: Bump BSK for missing Freemium RMF attribute
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
RemoteMessageClienttohttps://www.jsonblob.com/api/1313918156242345984RemoteMessagingConfigMatcherProviderat line 168, pass intrueforisCurrentFreemiumPIRUserDefinition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation