-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixels for Privacy Stats on HTML NTP #3659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected!
Are the pixel permanent? should we add tests for those?
Thanks @SabrinaTardio! Pixels are permanent. Show more/less events are tested in NewTabPagePrivacyStatsClientTests (to the point of being pushed to the event mapper - the receiver that fires pixels is trivial and doesn't need testing imo). Database error pixels aren't tested because it's tricky to break the database in unit tests, but the events are pushed from do-catch handlers for database operations so this is again straightforward. |
Task/Issue URL: https://app.asana.com/0/69071770703008/1208936504720914/f
Description:
This change adds 2 new messages to track actions in the Privacy Stats widget
and implements usage and debug pixels for Privacy Stats.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation