[WIP] Switch to tab implementation #3660
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasstrba
reviewed
Dec 12, 2024
There was a problem hiding this comment.
@mallexxx, this is really great feature, I love it! I added couple of comments below and would like to resolve a question of suggesting tabs between regular windows and Fire Windows in Asana.
Also, suggesting a pinned tab didn't work for me. Am I missing something?
| @@ -486,6 +488,21 @@ final class AddressBarTextField: NSTextField { | |||
| } | |||
| } | |||
|
|
|||
| private func switchTo(_ tab: OpenTab) { | |||
There was a problem hiding this comment.
Can we encapsulate this logic somewhere else? (standalone class maybe?) It is slightly confusing to have logic for switching tabs in AddressBarTextField
| @@ -52,8 +56,16 @@ final class SuggestionContainer { | |||
| let urlFactory = { urlString in | |||
| return URL.makeURL(fromSuggestionPhrase: urlString) | |||
| } | |||
|
|
|||
| self.init(suggestionLoading: SuggestionLoader(urlFactory: urlFactory), | |||
| let openTabsProvider: OpenTabsProvider = { @MainActor in | |||
There was a problem hiding this comment.
Would using WindowControllersManagerProtocol make more sense here since other data are passed this way too?
| @@ -787,6 +787,16 @@ extension TabCollectionViewModel { | |||
| return nil | |||
| } | |||
|
|
|||
| func indexInAllTabs(where condition: (Tab) -> Bool) -> TabIndex? { | |||
mallexxx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1202406491309510/1208236460435649/f
Tech Design URL: https://app.asana.com/0/72649045549333/1208270496320813/f
Description:
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation