Fix synchronous data removal from PixelDataStore cache #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Dec 22, 2021
| @@ -185,8 +186,6 @@ final class LocalPixelDataStore<T: NSManagedObject>: PixelDataStore { | |||
| let changes: [AnyHashable: Any] = [NSDeletedObjectsKey: deletedObjects] | |||
| NSManagedObjectContext.mergeChanges(fromRemoteContextSave: changes, into: [context]) | |||
|
|
|||
| self.cache.removeValue(forKey: key) | |||
There was a problem hiding this comment.
What are the odds that the try call earlier in this function fails? In that case, we'll have data removed from the cache but not from the DB. Is it worth repairing the cache in the catch block in case this happens? Admittedly I think the chances are slim.
There was a problem hiding this comment.
the cache is the source of truth here and if we get an error here it would be the database that needs to be restored - we've discussed this on our last Apple team meeting and this will be handled as a separate task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Tech Design URL:
CC:
Description:
Fixes Pixel Data Store Cached value available after removing a value from PixelDataStore (and later data race when removing the value from background thread)
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM