Code

Logins+ authentication#438

Code

Merged

samsymons merged 129 commits intodevelopduckduckgo/macos-browser:developfrom sam/logins-authenticationduckduckgo/macos-browser:sam/logins-authenticationCopy head branch name to clipboardMar 1, 2022

+1,774-98

Commits

Commits on Jan 20, 2022

• Scroll to credentials found on a website.

  samsymons

  committed
  a7f9c29

• Select the first login if the match isn't found.

  samsymons

  committed
  72d1a3f

Commits on Jan 24, 2022

• Merge branch 'develop' into sam/automatically-select-available-login

  Show description for f1b8abc
  samsymons

  committed
  f1b8abc

• Retain the filtering logic on 10.15.

  samsymons

  committed
  f8faa6f

• Remove the timer.

  samsymons

  committed
  c0e9caf

• Rename a view. Could still be clearer maybe?

  samsymons

  committed
  c235cad

Commits on Jan 26, 2022

• Merge branch 'develop' into sam/automatically-select-available-login

  samsymons

  authored
  c4751f5

• Drop the "www." prefix of domains when selecting.

  samsymons

  committed
  81a7285

Commits on Jan 28, 2022

• Work on login filtering.

  samsymons

  committed
  39dea60

Commits on Jan 30, 2022

• More sorting work. Inefficient at the moment though.

  samsymons

  committed
  887d6a7

Commits on Jan 31, 2022

• Add new menu items. Need proper pixels.

  samsymons

  committed
  0eb476f

• Update the images to be templates.

  samsymons

  committed
  c459235

• Fix unit tests.

  samsymons

  committed
  4b66fbd

• Move sorting code out into a separate file.

  samsymons

  committed
  2dfba9c

• More sorting work.

  samsymons

  committed
  eabe4b3

• Monitor the scroll offset to fade in the divider.

  samsymons

  committed
  6c871cb

• Merge branch 'develop' into sam/logins-filtering-and-sorting

  Show description for 97d93f6
  samsymons

  committed
  97d93f6

Commits on Feb 1, 2022

• Use the custom NSPopUpButton in the PWM list view.

  samsymons

  committed
  4fc8625

Commits on Feb 3, 2022

• Merge branch 'develop' into sam/logins-filtering-and-sorting

  Show description for ad3d2e2
  samsymons

  committed
  ad3d2e2

• Fix merge issues.

  samsymons

  committed
  c7c87ed

• Temporarily move back to VStack.

  samsymons

  committed
  35a92bd

• Update the sorting icon.

  samsymons

  committed
  ca2fbf9

Commits on Feb 6, 2022

• Update assets.

  samsymons

  committed
  e03692d

• Update filter UI styling.

  samsymons

  committed
  b856665

Commits on Feb 9, 2022

• Merge branch 'develop' into sam/logins-filtering-and-sorting

  Show description for 54882aa
  samsymons

  committed
  54882aa

• Rename some assets.

  samsymons

  committed
  9dcaba8

• Remove padding on the top section's title.

  samsymons

  committed
  3e731a0

• Use category colors for the pop up button.

  samsymons

  committed
  33f16e8

• Use the right appearance for allItems.

  samsymons

  committed
  91eb7b3

• Try adding an empty state.

  samsymons

  committed
  1a5fac1

Commits on Feb 10, 2022

• Merge branch 'develop' into sam/logins-filtering-and-sorting

  Show description for 3804c7c
  samsymons

  committed
  3804c7c

• Silence a build warning.

  samsymons

  committed
  db07e9b

• Add icons to the Add menu.

  samsymons

  committed
  52ca120

• Play with appearance changes.

  samsymons

  committed
  5aa0fee

Commits on Feb 13, 2022

• Merge branch 'develop' into sam/logins-filtering-and-sorting

  Show description for c3cef28
  samsymons

  committed
  c3cef28

• Add the rough PopUpButton implementation.

  samsymons

  committed
  a67d6b1

• Line up the category button frames.

  samsymons

  committed
  e80ee5a

• Change category picker colors.

  samsymons

  committed
  9fbe9e4

• Improve the way empty states are displayed.

  samsymons

  committed
  62d9001

Commits on Feb 14, 2022

• Avoid uppercasing the month string.

  samsymons

  committed
  3a9c8c2

Commits on Feb 15, 2022

• Merge branch 'develop' into sam/logins-filtering-and-sorting

  Show description for 001de8a
  samsymons

  committed
  001de8a

Commits on Feb 16, 2022

• Sort out the image rendering issue once and for all.

  samsymons

  committed
  c5f88a1

• Update pixels.

  samsymons

  committed
  f4d4775

• Work on self-review items.

  samsymons

  committed
  4580db9

• Fix unit test compilation.

  samsymons

  committed
  51d5d38

• Add list section unit tests.

  samsymons

  committed
  0581643

• Move strings into UserText.

  samsymons

  committed
  b58da31

• Add another section test.

  samsymons

  committed
  7d4d388

• More UserText changes.

  samsymons

  committed
  48a6315

• Fix a compilation error when building for release.

  samsymons

  committed
  2e6ec34

• Remember the sort descriptor when opening Logins+.

  samsymons

  committed
  578b499

• Fix the image issue… again!

  samsymons

  committed
  ac0d48b

• Partially fix the preferences divider rendering.

  samsymons

  committed
  0e2b7dd

• Test out a way to detect the idle state of the system.

  samsymons

  committed
  21f351a

• Add the initial UI for Logins+ authentication.

  samsymons

  committed
  c067185

• Store preferences in user defaults.

  samsymons

  committed
  9328c21

• Begin sketching out the authentication service flow.

  samsymons

  committed
  8e841a9

• Avoid closing the popover when authenticating.

  samsymons

  committed
  aa355b9

Commits on Feb 17, 2022

• Add logging.

  samsymons

  committed
  8a78f9e

• Implement more of the lock screen.

  samsymons

  committed
  ac053a3

• Make sure that the timer runs all the time.

  samsymons

  committed
  a397cf9

• Lock Logins+ while it’s visible.

  samsymons

  committed
  b12faef

• Use the correct LAContext policy.

  samsymons

  committed
  e9c10a1

• Add a new background color for the Auto-Lock screen.

  samsymons

  committed
  a022250

• Rig up the user preferences link.

  samsymons

  committed
  ef68ed8

• Use the correct asset for the device state.

  samsymons

  committed
  c833d1f

• Change the timer to 30 seconds.

  samsymons

  committed
  122d558

• Make sure that the New Item buttons always work.

  samsymons

  committed
  eca52f1

• Always authenticate credit card information.

  samsymons

  committed
  7d0bcc1

• Set the dev timer to 15 seconds.

  samsymons

  committed
  35be5ed

Commits on Feb 18, 2022

• Clean up some table view positioning.

  samsymons

  committed
  97bdc42

• Prevent the GPC text from intercepting scrolling.

  samsymons

  committed
  c81f8a3

• More layout refinement.

  samsymons

  committed
  80d90bf

• Tweak cell resizing.

  samsymons

  committed
  9f0cdf1

• Clean up warnings.

  samsymons

  committed
  8f3d8df

• Intercept click events inside ColorView.

  samsymons

  committed
  a7f9ab3

• Fix lock screen text colors.

  samsymons

  committed
  6e94aec

• Merge branch 'develop' into sam/logins-filtering-and-sorting

  Show description for bc04eb4
  samsymons

  committed
  bc04eb4

• Re-enable a SwiftLint warning fix.

  samsymons

  committed
  7c07d51

• Ensure that items within sections are sorted correctly.

  samsymons

  committed
  145518d

• Merge branch 'sam/logins-filtering-and-sorting' into sam/logins-authentication

  Show description for b663971
  samsymons

  committed
  b663971

• Use an empty to calculate the empty state.

  samsymons

  committed
  000bc14

• Update unit tests to reflect the sorting change.

  samsymons

  committed
  532070b

• Add some unit tests for the new empty state logic.

  samsymons

  committed
  3ecace9

• Fix self-review comments.

  samsymons

  committed
  15d5d46

• Clean up some string value calculation.

  samsymons

  committed
  c41e9f2

Commits on Feb 19, 2022

• Clean up the new menu code.

  samsymons

  committed
  f4e940a

• Swap to the correct category when selecting an item.

  samsymons

  committed
  fcaf462

• Merge branch 'sam/logins-filtering-and-sorting' into sam/logins-authentication

  Show description for d7327bc
  samsymons

  committed
  d7327bc

• Use the correct color for the unlock button.

  samsymons

  committed
  c96a855

• Dismiss the logins popover when clicking the Preferences button.

  samsymons

  committed
  9f04035

• Remove first responder when showing the lock screen.

  samsymons

  committed
  185dc0c

• Clean up the NSImage tint function.

  samsymons

  committed
  905e542

• Move the empty state code to its own section.

  samsymons

  committed
  cffd948

Commits on Feb 21, 2022

• Update the way selected items are managed.

  samsymons

  committed
  156a0d5

• Disable category changes when editing.

  samsymons

  committed
  7e6796d

• Merge branch 'sam/logins-filtering-and-sorting' into sam/logins-authentication

  Show description for b8b19d3
  samsymons

  committed
  b8b19d3

• Merge branch 'develop' into sam/logins-filtering-and-sorting

  Show description for 610583e
  samsymons

  committed
  610583e

• Merge branch 'sam/logins-filtering-and-sorting' into sam/logins-authentication

  Show description for 66fac7a
  samsymons

  committed
  66fac7a

• Don’t request permission every time settings change.

  samsymons

  committed
  e0f59c3

• Hide the password manager popover if clicking the button while it’s already visible.

  samsymons

  committed
  61b9dc6

• Avoid the default empty state appearing at unexpected times.

  samsymons

  committed
  ecd6d68

• Merge branch 'sam/logins-filtering-and-sorting' into sam/logins-authentication

  Show description for bd62272
  samsymons

  committed
  bd62272

Commits on Feb 22, 2022

• Apply more dependency injection to the DeviceAuthenticator.

  samsymons

  committed
  aeb650c

• Add unit tests.

  samsymons

  committed
  eb9fc5b

• Merge branch 'develop' into sam/logins-filtering-and-sorting

  Show description for 09d7ec2
  samsymons

  committed
  09d7ec2

• Disable the search field when editing.

  samsymons

  committed
  f187c96

Commits on Feb 23, 2022

• Merge branch 'sam/logins-filtering-and-sorting' into sam/logins-authentication

  Show description for b31e6a2
  samsymons

  committed
  b31e6a2

• Point to the logins authentication BSK branch.

  samsymons

  committed
  b8351d7

• Add pixels.

  samsymons

  committed
  7848480

• Clean up some commented code.

  samsymons

  committed
  c02ec3e

• Fix a compilation error.

  samsymons

  committed
  4c3864f

Commits on Feb 24, 2022

• Merge branch 'develop' into sam/logins-authentication

  Show description for 57c215f
  samsymons

  committed
  57c215f

• Fix a couple last-minute issues.

  samsymons

  committed
  88e0361

• Display the correct unlock reason.

  samsymons

  committed
  8144fe3

• Resolve self-review comments.

  samsymons

  committed
  89a95ce

• Set the privacy dashboard back to the correct version.

  samsymons

  committed
  b9751ca

• Remove a duplicate file.

  samsymons

  committed
  4012441

• Remove the App Delegate timer call.

  Show description for 47beac6
  samsymons

  committed
  47beac6

• Fix unit tests.

  samsymons

  committed
  387b239

• Resolve warnings now that Logins preferences aren’t a struct.

  samsymons

  committed
  89a33cb

• Move remaining strings into UserText.

  samsymons

  committed
  467434f

Commits on Feb 25, 2022

• update packages resolved

  brindy

  committed
  2987dfe

• Merge branch 'develop' into sam/logins-authentication

  Show description for 1db7eb0
  samsymons

  committed
  1db7eb0

• Update the logins authentication BSK commit.

  samsymons

  committed
  7b3d8eb

• Use an enum to return the authentication state.

  samsymons

  committed
  9c8c2f5

Commits on Feb 27, 2022

• Update ContentOverlayViewController to implement SecureVaultManagerDelegate.

  samsymons

  committed
  9b518af

Commits on Mar 1, 2022

• Merge branch 'develop' into sam/logins-authentication

  Show description for 2cda779
  samsymons

  committed
  2cda779

• Point to BSK 11.0.0.

  samsymons

  committed
  fc2d6b0