Add a script to update embedded data #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
force-pushed
the
dominik/embedded-data-update-script
branch
from
f505b9b to
72941ca
Compare
|
My apology for the slow review. I will prioritize this tomorrow and try to merge if everything looks good. |
1 similar comment
|
My apology for the slow review. I will prioritize this tomorrow and try to merge if everything looks good. |
|
Merging this since Dominik is out |
samsymons
added a commit
that referenced
this pull request
Jun 12, 2022
# By Dominik Kapusta (9) and others # Via Chris Brind (2) and others * develop: (23 commits) Improve build phase times during compilation (#607) bump version First reponder fixed when a child tab is created (#612) always read/write directly from the backing store (#613) Bump privacy dashboard to latest version (#614) Bump privacy dashboard to latest version (#608) Update BSK to include ios autofill changes (#606) Fire autofill pixel from overlay (#611) Autoconsent group without folder refactored back to group (#610) Favicon image not highlighted when pressed (#609) Update symbolicate.js to handle ips files without asiBacktraces (#602) Add a script to update embedded data (#599) Version 0.26.1 Add support for importing bookmarks from HTML file (#603) Update TRK (#592) Shane/inline icon flag (#604) Use Xcode 13.4 in GitHub Actions (#600) Support securevault delegate settings for auto-save (#598) Bump version number to 0.26.0 Do not call makeKey on windows created in windows deallocation test (#601) ... # Conflicts: # DuckDuckGo/Common/Utilities/UserDefaultsWrapper.swift # DuckDuckGo/Data Import/View/DataImport.storyboard # DuckDuckGo/Menus/MainMenu.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202355163273999/f
Description:
Based on Bartek's script used in iOS.
Steps to test this PR:
The script:
$ ./scripts/update_embedded.shAppTrackerDataSetProvider.constants.embeddedDataETagAppPrivacyConfigurationDataProvider.constants.embeddedDataETag\"in place though as they're required for the script to recognize the ETag.The app:
staticcdn.duckduckgo.com localhostline at the bottom$ ./clean-app.sh debug/etc/hosts:)Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM