Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard #660

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Update dashboard #660

merged 2 commits into from
Jul 27, 2022

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1202675340331509/f
Tech Design URL:
CC:

Description:
This PR updates the privacy dashboard to say Cookies Managed instead of Cookies Minimized.

Steps to test this PR:

  1. Visit https://privacy-test-pages.glitch.me/features/autoconsent/
  2. Open the dashboard. At the bottom it should say "Cookies Managed" not "Cookies Minimized"

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
image

@SlayterDev SlayterDev merged commit cd04645 into develop Jul 27, 2022
@SlayterDev SlayterDev deleted the brad/cookie-text branch July 27, 2022 16:22
samsymons added a commit that referenced this pull request Jul 28, 2022
* develop:
  Don't use PinnedTabsManager for popup windows (#658)
  Fix a memory leak when closing a popup window (#657)
  Update dashboard (#660)
samsymons added a commit that referenced this pull request Jul 28, 2022
…improvements-phase-2

* sam/bookmarks-improvements-phase-1:
  Fingerprinting Protections (#648)
  Preserve the order of bookmark entities after dragging.
  Fix an out of bounds crash.
  Don't use PinnedTabsManager for popup windows (#658)
  Fix a memory leak when closing a popup window (#657)
  Update dashboard (#660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants