Skip to content

Commit

Permalink
Upgrade ESLint and introduce Prettier (#2451)
Browse files Browse the repository at this point in the history
* Use shared eslint config and introduce Prettier

* Fix eslint issues

* Add prettier config

* Apply Prettier

* Rely on eslint and prettier in github checks

* Bring back the format command

* Fix lint issues after merge
  • Loading branch information
muodov authored Nov 13, 2024
1 parent abf8d7d commit d65853c
Show file tree
Hide file tree
Showing 47 changed files with 2,419 additions and 3,492 deletions.
Empty file removed .eslintignore
Empty file.
11 changes: 0 additions & 11 deletions .eslintrc

This file was deleted.

128 changes: 64 additions & 64 deletions .github/ISSUE_TEMPLATE/breakage-form.yml
Original file line number Diff line number Diff line change
@@ -1,68 +1,68 @@
---
name: Site Breakage Form
description: Report a website issue on a DuckDuckGo app or browser extension
title: "Broken Site: "
title: 'Broken Site: '
body:
- type: markdown
attributes:
value: |
Thanks for reporting a broken site! Please add the domain you're reporting to the title of this issue above.
- type: textarea
id: urls
attributes:
label: URLs affected
description: On which URLs are you seeing the problem?
placeholder: https://example.com/page.html?product=shoes
validations:
required: true
- type: textarea
id: description
attributes:
label: Description of Breakage
description: What is broken and how it is broken? (Include screenshots if possible)
placeholder: Page is blank for 5s after loading
validations:
required: true
- type: checkboxes
id: affected-platforms
attributes:
label: Affected Platforms
description: Which DuckDuckGo products are affected by this breakage?
options:
- label: Browser Extensions
- label: Android Browser
- label: iOS Browser
- label: macOS Browser
- label: Windows Browser
validations:
required: true
- type: textarea
id: other
attributes:
label: Other Details
description: Any other information that might help us to investigate and fix your reported site?
- type: markdown
attributes:
value: |
## Additional Information
- type: dropdown
id: disable-privacy-protection
attributes:
label: Tested without Privacy Protections
description: Does the site work if Privacy Protections are turned off?
options:
- "Yes"
- "No"
- "I don't know what this means"
validations:
required: true
- type: dropdown
id: verified-on-other-browsers
attributes:
label: Verified on other browsers
description: Does this breakage occur on other non-DuckDuckGo browsers?
options:
- "Yes"
- "No"
validations:
required: true
- type: markdown
attributes:
value: |
Thanks for reporting a broken site! Please add the domain you're reporting to the title of this issue above.
- type: textarea
id: urls
attributes:
label: URLs affected
description: On which URLs are you seeing the problem?
placeholder: https://example.com/page.html?product=shoes
validations:
required: true
- type: textarea
id: description
attributes:
label: Description of Breakage
description: What is broken and how it is broken? (Include screenshots if possible)
placeholder: Page is blank for 5s after loading
validations:
required: true
- type: checkboxes
id: affected-platforms
attributes:
label: Affected Platforms
description: Which DuckDuckGo products are affected by this breakage?
options:
- label: Browser Extensions
- label: Android Browser
- label: iOS Browser
- label: macOS Browser
- label: Windows Browser
validations:
required: true
- type: textarea
id: other
attributes:
label: Other Details
description: Any other information that might help us to investigate and fix your reported site?
- type: markdown
attributes:
value: |
## Additional Information
- type: dropdown
id: disable-privacy-protection
attributes:
label: Tested without Privacy Protections
description: Does the site work if Privacy Protections are turned off?
options:
- 'Yes'
- 'No'
- "I don't know what this means"
validations:
required: true
- type: dropdown
id: verified-on-other-browsers
attributes:
label: Verified on other browsers
description: Does this breakage occur on other non-DuckDuckGo browsers?
options:
- 'Yes'
- 'No'
validations:
required: true
38 changes: 19 additions & 19 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
version: 2
updates:
- package-ecosystem: "npm"
directory: "/"
schedule:
interval: "daily"
open-pull-requests-limit: 20
target-branch: "main"
labels:
- "dependencies"
groups:
build:
patterns:
- "eslint*"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
target-branch: "main"
labels:
- "dependencies"
- package-ecosystem: 'npm'
directory: '/'
schedule:
interval: 'daily'
open-pull-requests-limit: 20
target-branch: 'main'
labels:
- 'dependencies'
groups:
build:
patterns:
- 'eslint*'
- package-ecosystem: 'github-actions'
directory: '/'
schedule:
interval: 'weekly'
target-branch: 'main'
labels:
- 'dependencies'
10 changes: 5 additions & 5 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!--
<!--
⚠️ ⚠️ IF YOU ARE MODIFYING `index.js` OR A FILE IN `features` ⚠️ ⚠️
Please request a review and ping a DRI from the Config AOR or Breakage AOR.
The quickest way to get attention for your PR is to ping the ~Breakage channel
Expand All @@ -10,16 +10,16 @@
as it's reviewed.
-->


**Asana Task/Github Issue:**

## Description

<!--
If this is a SITE BREAKAGE MITIGATION, please include a BRIEF EXPLANATION that covers the REPORTED URL, the PLATFORMS AFFECTED, and the TRACKER(S) being unblocked or FEATURE being disabled, as well as a mention of the PROBLEM(S) users are experiencing. Please also check that you have referenced the URL of this PR as the "reason" value for the exception (where applicable).
-->

#### Reference
- [Config Reviewer Documentation](https://app.asana.com/0/1200890834746050/1204443212791216/f)
- [Config Maintainer Documentation](https://app.asana.com/0/1200890834746050/1200573250322769/f)
- [Feature Implementer Documentation](https://app.asana.com/0/1200890834746050/1201498956177210/f)

- [Config Reviewer Documentation](https://app.asana.com/0/1200890834746050/1204443212791216/f)
- [Config Maintainer Documentation](https://app.asana.com/0/1200890834746050/1200573250322769/f)
- [Feature Implementer Documentation](https://app.asana.com/0/1200890834746050/1201498956177210/f)
Loading

0 comments on commit d65853c

Please sign in to comment.