Add support for voice search #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisBarreiro
force-pushed
the
feature/cbarreiro/voice-search
branch
4 times, most recently
from
cff91ef to
4f48e7f
Compare
CrisBarreiro
force-pushed
the
feature/cbarreiro/voice-search
branch
from
4f48e7f to
db1509c
Compare
|
Generated file outputs: legacyfingerprinting.json (3 more)
v1/android-config.json (1 more)
--- v2/android-config.json
+++ v2/android-config.json
@@ -7069,8 +7069,16 @@
},
"exceptions": [],
"state": "disabled"
},
+ "voiceSearch": {
+ "exceptions": [],
+ "state": "enabled",
+ "settings": {
+ "minVersion": 33,
+ "excludedManufacturers": []
+ }
+ },
"webCompat": {
"exceptions": [],
"state": "enabled",
"settings": {
v1/extension-brave-config.json (25 more)
--- v2/windows-config.json
+++ v2/windows-config.json
@@ -6331,8 +6331,12 @@
},
"exceptions": [],
"state": "disabled"
},
+ "voiceSearch": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"webCompat": {
"exceptions": [],
"state": "disabled"
},
latestv3/android-config.json--- v3/android-config.json
+++ v3/android-config.json
@@ -7076,8 +7076,16 @@
},
"exceptions": [],
"state": "disabled"
},
+ "voiceSearch": {
+ "exceptions": [],
+ "state": "enabled",
+ "settings": {
+ "minVersion": 33,
+ "excludedManufacturers": []
+ }
+ },
"webCompat": {
"exceptions": [],
"state": "enabled",
"settings": {
v3/extension-brave-config.json (12 more)
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -6338,8 +6338,12 @@
},
"exceptions": [],
"state": "disabled"
},
+ "voiceSearch": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"webCompat": {
"exceptions": [],
"state": "disabled"
},
|
25 tasks
|
Generated file outputs: legacyfingerprinting.json (3 more)
v1/android-config.json (1 more)
--- v2/android-config.json
+++ v2/android-config.json
@@ -7069,8 +7069,16 @@
},
"exceptions": [],
"state": "disabled"
},
+ "voiceSearch": {
+ "exceptions": [],
+ "state": "enabled",
+ "settings": {
+ "minVersion": 33,
+ "excludedManufacturers": []
+ }
+ },
"webCompat": {
"exceptions": [],
"state": "enabled",
"settings": {
v1/extension-brave-config.json (25 more)
--- v2/windows-config.json
+++ v2/windows-config.json
@@ -6331,8 +6331,12 @@
},
"exceptions": [],
"state": "disabled"
},
+ "voiceSearch": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"webCompat": {
"exceptions": [],
"state": "disabled"
},
latestv3/android-config.json--- v3/android-config.json
+++ v3/android-config.json
@@ -7076,8 +7076,16 @@
},
"exceptions": [],
"state": "disabled"
},
+ "voiceSearch": {
+ "exceptions": [],
+ "state": "enabled",
+ "settings": {
+ "minVersion": 33,
+ "excludedManufacturers": []
+ }
+ },
"webCompat": {
"exceptions": [],
"state": "enabled",
"settings": {
v3/extension-brave-config.json (12 more)
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -6338,8 +6338,12 @@
},
"exceptions": [],
"state": "disabled"
},
+ "voiceSearch": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"webCompat": {
"exceptions": [],
"state": "disabled"
},
|
CrisBarreiro
added a commit
to duckduckgo/Android
that referenced
this pull request
Oct 11, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205292240653427/f Project: https://app.asana.com/0/72649045549333/1205122648906231/f Depends on duckduckgo/privacy-configuration#1229 ### Description Use remote config to determine whether or not to show voice search ### Steps to test this PR Sample ``` "voiceSearch": { "exceptions": [], "state": "enabled", "settings": { "minVersion": 33, "excludedManufacturers": [ { "name": "{manufacturerName}" } ] } }, ``` _Feature enabled, no excluded manufacturers, device running Android 13 -> Voice search icon_ - [x] Run the app on a device with Android 13 - [x] Create a copy of remote config using the sample above - [x] Remove all values from `excludedManufacturers` - [x] Open the app - [x] Look for a microphone icon on the search bar _Feature enabled, excluded manufacturers with other values, device running Android 13 -> Voice search icon_ - [x] Run the app on a device with Android 13 - [x] Create a copy of remote config using the sample above - [x] Add a manufacturer different than the current one to `excludedManufacturers` - [x] Open the app - [x] Look for a microphone icon on the search bar _Feature enabled, excluded manufacturers with other values, device running Android 12 -> No voice search icon_ - [x] Run the app on a device with Android 12 - [x] Create a copy of remote config using the sample above - [x] Add a manufacturer different than the current one to `excludedManufacturers` - [x] Open the app - [x] There's no microphone icon on the search bar _Feature enabled, excluded manufacturers with other values, device running Android 13 -> No voice search icon_ - [x] Run the app on a device with Android 13 - [x] Create a copy of remote config using the sample above - [x] Add current manufacturer to `excludedManufacturers` - [x] Open the app - [x] There's no microphone icon on the search bar _Feature disabled, no excluded manufacturers, device running Android 13 -> No voice search icon_ - [x] Run the app on a device with Android 13 - [x] Create a copy of remote config using the sample above - [x] Remove all values from `excludedManufacturers` - [x] Open the app - [x] There's no microphone icon on the search bar --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com>
joshliebe
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Nov 7, 2023
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) If your PR does not involve UI changes, you can remove the **UI changes** section At a minimum, make sure your changes are tested in API 23 and one of the more recent API levels available. --> Task/Issue URL: https://app.asana.com/0/0/1205292240653427/f Project: https://app.asana.com/0/72649045549333/1205122648906231/f Depends on duckduckgo/privacy-configuration#1229 ### Description Use remote config to determine whether or not to show voice search ### Steps to test this PR Sample ``` "voiceSearch": { "exceptions": [], "state": "enabled", "settings": { "minVersion": 33, "excludedManufacturers": [ { "name": "{manufacturerName}" } ] } }, ``` _Feature enabled, no excluded manufacturers, device running Android 13 -> Voice search icon_ - [x] Run the app on a device with Android 13 - [x] Create a copy of remote config using the sample above - [x] Remove all values from `excludedManufacturers` - [x] Open the app - [x] Look for a microphone icon on the search bar _Feature enabled, excluded manufacturers with other values, device running Android 13 -> Voice search icon_ - [x] Run the app on a device with Android 13 - [x] Create a copy of remote config using the sample above - [x] Add a manufacturer different than the current one to `excludedManufacturers` - [x] Open the app - [x] Look for a microphone icon on the search bar _Feature enabled, excluded manufacturers with other values, device running Android 12 -> No voice search icon_ - [x] Run the app on a device with Android 12 - [x] Create a copy of remote config using the sample above - [x] Add a manufacturer different than the current one to `excludedManufacturers` - [x] Open the app - [x] There's no microphone icon on the search bar _Feature enabled, excluded manufacturers with other values, device running Android 13 -> No voice search icon_ - [x] Run the app on a device with Android 13 - [x] Create a copy of remote config using the sample above - [x] Add current manufacturer to `excludedManufacturers` - [x] Open the app - [x] There's no microphone icon on the search bar _Feature disabled, no excluded manufacturers, device running Android 13 -> No voice search icon_ - [x] Run the app on a device with Android 13 - [x] Create a copy of remote config using the sample above - [x] Remove all values from `excludedManufacturers` - [x] Open the app - [x] There's no microphone icon on the search bar --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/0/1205256695374307/f
Description
Add support for voice search
Reference