re-enable autoconsent on Windows using the "enableIfMainWorldIsSuppoted" setting #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated file outputs: legacyfingerprinting.json (3 more)
v1/android-config.json (1 more)
--- v2/android-config.json
+++ v2/android-config.json
@@ -7069,16 +7069,8 @@
},
"exceptions": [],
"state": "disabled"
},
- "voiceSearch": {
- "exceptions": [],
- "state": "enabled",
- "settings": {
- "minVersion": 33,
- "excludedManufacturers": []
- }
- },
"webCompat": {
"exceptions": [],
"state": "enabled",
"settings": {
v1/extension-brave-config.json (23 more)
--- v2/macos-config.json
+++ v2/macos-config.json
@@ -6341,12 +6341,8 @@
},
"exceptions": [],
"state": "disabled"
},
- "voiceSearch": {
- "exceptions": [],
- "state": "disabled"
- },
"webCompat": {
"exceptions": [
{
"domain": "lastpass.com",
v1/windows-config.json--- v1/windows-config.json
+++ v1/windows-config.json
@@ -243,9 +243,10 @@
],
"settings": {
"disabledCMPs": [
"generic-cosmetic"
- ]
+ ],
+ "enableIfMainWorldIsSupported": "enabled"
},
"state": "disabled"
},
"autofill": {
@@ -6338,12 +6339,8 @@
},
"exceptions": [],
"state": "disabled"
},
- "voiceSearch": {
- "exceptions": [],
- "state": "disabled"
- },
"webCompat": {
"exceptions": [],
"state": "disabled"
},
v2/windows-config.json--- v2/windows-config.json
+++ v2/windows-config.json
@@ -243,11 +243,13 @@
],
"settings": {
"disabledCMPs": [
"generic-cosmetic"
- ]
+ ],
+ "enableIfMainWorldIsSupported": "enabled"
},
- "state": "disabled"
+ "state": "disabled",
+ "minSupportedVersion": "0.50.0"
},
"autofill": {
"exceptions": [
{
@@ -6331,12 +6333,8 @@
},
"exceptions": [],
"state": "disabled"
},
- "voiceSearch": {
- "exceptions": [],
- "state": "disabled"
- },
"webCompat": {
"exceptions": [],
"state": "disabled"
},
latestv3/android-config.json--- v3/android-config.json
+++ v3/android-config.json
@@ -7076,16 +7076,8 @@
},
"exceptions": [],
"state": "disabled"
},
- "voiceSearch": {
- "exceptions": [],
- "state": "enabled",
- "settings": {
- "minVersion": 33,
- "excludedManufacturers": []
- }
- },
"webCompat": {
"exceptions": [],
"state": "enabled",
"settings": {
v3/extension-brave-config.json (11 more)
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -6348,12 +6348,8 @@
},
"exceptions": [],
"state": "disabled"
},
- "voiceSearch": {
- "exceptions": [],
- "state": "disabled"
- },
"webCompat": {
"exceptions": [
{
"domain": "lastpass.com",
v3/windows-config.json--- v3/windows-config.json
+++ v3/windows-config.json
@@ -243,11 +243,13 @@
],
"settings": {
"disabledCMPs": [
"generic-cosmetic"
- ]
+ ],
+ "enableIfMainWorldIsSupported": "enabled"
},
- "state": "disabled"
+ "state": "disabled",
+ "minSupportedVersion": "0.50.0"
},
"autofill": {
"exceptions": [
{
@@ -6338,12 +6340,8 @@
},
"exceptions": [],
"state": "disabled"
},
- "voiceSearch": {
- "exceptions": [],
- "state": "disabled"
- },
"webCompat": {
"exceptions": [],
"state": "disabled"
},
|
…s well, just to be on the safe side
|
Generated file outputs: legacyfingerprinting.json (29 more)
v1/windows-config.json--- v1/windows-config.json
+++ v1/windows-config.json
@@ -243,9 +243,13 @@
],
"settings": {
"disabledCMPs": [
"generic-cosmetic"
- ]
+ ],
+ "enableIfMainWorldIsSupported": {
+ "state": "enabled",
+ "minSupportedVersion": "0.50.0"
+ }
},
"state": "disabled"
},
"autofill": {
v2/windows-config.json--- v2/windows-config.json
+++ v2/windows-config.json
@@ -243,11 +243,16 @@
],
"settings": {
"disabledCMPs": [
"generic-cosmetic"
- ]
+ ],
+ "enableIfMainWorldIsSupported": {
+ "state": "enabled",
+ "minSupportedVersion": "0.50.0"
+ }
},
- "state": "disabled"
+ "state": "disabled",
+ "minSupportedVersion": "0.50.0"
},
"autofill": {
"exceptions": [
{
latestv3/android-config.json (12 more)
v3/windows-config.json--- v3/windows-config.json
+++ v3/windows-config.json
@@ -243,11 +243,16 @@
],
"settings": {
"disabledCMPs": [
"generic-cosmetic"
- ]
+ ],
+ "enableIfMainWorldIsSupported": {
+ "state": "enabled",
+ "minSupportedVersion": "0.50.0"
+ }
},
- "state": "disabled"
+ "state": "disabled",
+ "minSupportedVersion": "0.50.0"
},
"autofill": {
"exceptions": [
{
|
SlayterDev
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/0/1205319036091446/f
cc: @muodov @SlayterDev
Description
In #1212 we temporarily disabled autoconsent.
Now we would like to enable it again, but:
We wanted to use
minSupportedVersionto achieve our goals, but the native service handler don't takeminSupportedVersioninto account at all and only listen to the global state enabled/disabled flag.As a workaround and/or improvement:
minSupportedVersionand implemented the proper client side handling of that propertyenableIfMainWorldIsSuppotedwhich will temporarily act as a enabled/disabled flag and we'll keep top level global state flag disabled, until almost everyone is updated to v0.50 or higher. Then we will remove theenableIfMainWorldIsSuppotedand flip the global disabled to enabled.Reference