-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autofill] add feature toggle for partial save for android and windows #2593
Conversation
Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
Generated file outputs:Time updated: Tue, 17 Dec 2024 15:38:10 GMT legacytrackers-unprotected-temporary.txt (12 more)
v3/android-config.json--- v3/android-config.json
+++ v3/android-config.json
@@ -1930,8 +1930,11 @@
},
"canIntegrateWebMessageBasedAutofillInWebView": {
"state": "disabled"
},
+ "partialFormSaves": {
+ "state": "enabled"
+ },
"onByDefault": {
"state": "enabled",
"rollout": {
"steps": [
v3/windows-config.json--- v3/windows-config.json
+++ v3/windows-config.json
@@ -1125,8 +1125,11 @@
"state": "enabled"
},
"credentialsImportPromotionForExistingUsers": {
"state": "enabled"
+ },
+ "partialFormSaves": {
+ "state": "disabled"
}
}
},
"backgroundAgentPixelTest": {
latestv4/android-config.json--- v4/android-config.json
+++ v4/android-config.json
@@ -1698,8 +1698,11 @@
},
"canIntegrateWebMessageBasedAutofillInWebView": {
"state": "disabled"
},
+ "partialFormSaves": {
+ "state": "enabled"
+ },
"onByDefault": {
"state": "enabled",
"rollout": {
"steps": [
v4/extension-brave-config.json (11 more)
v4/windows-config.json--- v4/windows-config.json
+++ v4/windows-config.json
@@ -898,8 +898,11 @@
"state": "enabled"
},
"credentialsImportPromotionForExistingUsers": {
"state": "enabled"
+ },
+ "partialFormSaves": {
+ "state": "disabled"
}
}
},
"backgroundAgentPixelTest": {
|
3ff56ad
to
75f23d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows side LGTM.
9ab6ac5
to
0e3ef93
Compare
0e3ef93
to
9a62e8d
Compare
Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1208998878408133/f
Description
The Increase ratio of complete credentials saves [3w] project adds the in-memory saving of partial credentials during multi-page login / registration / password-reset flows. In order to reduce any risk of autofill breakage introduced by this change, we should add a feature flag that can be used to remotely deactivate the functionality in the case that we receive reports of problems.
Note: Currently doesn't effect either Windows or Android as they don't consume it yet, it's for future proofing.
Feature change process:
Additional info:
Site breakage mitigation process:
Brief explanation
Reported URL:
Problems experienced:
Platforms affected:
Tracker(s) being unblocked:
Feature being disabled:
I have referenced the URL of this PR as the "reason" value for the exception (where applicable).
This change is a speculative mitigation to fix reported breakage.
Reference