Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autofill] add feature toggle for partial save for android and windows #2593

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

dbajpeyi
Copy link
Contributor

@dbajpeyi dbajpeyi commented Dec 17, 2024

Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1208998878408133/f

Description

The Increase ratio of complete credentials saves [3w] project adds the in-memory saving of partial credentials during multi-page login / registration / password-reset flows. In order to reduce any risk of autofill breakage introduced by this change, we should add a feature flag that can be used to remotely deactivate the functionality in the case that we receive reports of problems.

Note: Currently doesn't effect either Windows or Android as they don't consume it yet, it's for future proofing.

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

Copy link

Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana).
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Dec 17, 2024

Generated file outputs:

Time updated: Tue, 17 Dec 2024 15:38:10 GMT

legacy
trackers-unprotected-temporary.txt (12 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -1930,8 +1930,11 @@
                 },
                 "canIntegrateWebMessageBasedAutofillInWebView": {
                     "state": "disabled"
                 },
+                "partialFormSaves": {
+                    "state": "enabled"
+                },
                 "onByDefault": {
                     "state": "enabled",
                     "rollout": {
                         "steps": [
v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -1125,8 +1125,11 @@
                     "state": "enabled"
                 },
                 "credentialsImportPromotionForExistingUsers": {
                     "state": "enabled"
+                },
+                "partialFormSaves": {
+                    "state": "disabled"
                 }
             }
         },
         "backgroundAgentPixelTest": {
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -1698,8 +1698,11 @@
                 },
                 "canIntegrateWebMessageBasedAutofillInWebView": {
                     "state": "disabled"
                 },
+                "partialFormSaves": {
+                    "state": "enabled"
+                },
                 "onByDefault": {
                     "state": "enabled",
                     "rollout": {
                         "steps": [
v4/extension-brave-config.json (11 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json

⚠️ File is identical

v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -898,8 +898,11 @@
                     "state": "enabled"
                 },
                 "credentialsImportPromotionForExistingUsers": {
                     "state": "enabled"
+                },
+                "partialFormSaves": {
+                    "state": "disabled"
                 }
             }
         },
         "backgroundAgentPixelTest": {

@dbajpeyi dbajpeyi changed the title chore: add feature toggle for partial save [Autofill] add feature toggle for partial save for android and windows Dec 17, 2024
@dbajpeyi dbajpeyi marked this pull request as ready for review December 17, 2024 14:03
@dbajpeyi dbajpeyi requested review from a team as code owners December 17, 2024 14:03
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/add-partial-save-feature-toggle branch from 3ff56ad to 75f23d8 Compare December 17, 2024 14:25
gkerenyi
gkerenyi previously approved these changes Dec 17, 2024
Copy link
Contributor

@gkerenyi gkerenyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows side LGTM.

@dbajpeyi dbajpeyi force-pushed the dbajpeyi/add-partial-save-feature-toggle branch 2 times, most recently from 9ab6ac5 to 0e3ef93 Compare December 17, 2024 14:40
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/add-partial-save-feature-toggle branch from 0e3ef93 to 9a62e8d Compare December 17, 2024 15:37
@gkerenyi gkerenyi added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit b834e75 Dec 18, 2024
9 checks passed
@gkerenyi gkerenyi deleted the dbajpeyi/add-partial-save-feature-toggle branch December 18, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants