Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add History page feature #2726

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

greyivy
Copy link
Contributor

@greyivy greyivy commented Feb 5, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1208850639107971/f

Description

Adds a new web-based History page feature (for use on Windows and macOS). Distinct to the less-specific https://github.com/duckduckgo/privacy-configuration/blob/main/features/history.json feature and follows https://github.com/duckduckgo/privacy-configuration/blob/main/features/html-new-tab-page.json naming convention.

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@greyivy greyivy requested review from a team as code owners February 5, 2025 19:40
@greyivy greyivy requested a review from ayoy February 5, 2025 19:40
Copy link

github-actions bot commented Feb 5, 2025

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Feb 5, 2025

Generated file outputs:

Time updated: Wed, 05 Feb 2025 19:41:04 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (13 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -6371,8 +6371,12 @@
         "history": {
             "state": "disabled",
             "exceptions": []
         },
+        "htmlHistoryPage": {
+            "state": "disabled",
+            "exceptions": []
+        },
         "htmlNewTabPage": {
             "state": "disabled",
             "exceptions": [],
             "features": {
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -5885,8 +5885,12 @@
         "history": {
             "state": "disabled",
             "exceptions": []
         },
+        "htmlHistoryPage": {
+            "state": "disabled",
+            "exceptions": []
+        },
         "htmlNewTabPage": {
             "state": "disabled",
             "exceptions": [],
             "features": {

@greyivy
Copy link
Contributor Author

greyivy commented Feb 5, 2025

How does this sound to you @ayoy ?

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @greyivy! I was considering dropping the html prefix because there's no other history page anywhere yet, but it doesn't hurt to be specific :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants