Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hot reloading of configuration #53

Closed
patriksvensson opened this issue Mar 15, 2020 · 0 comments · Fixed by #56
Closed

Add hot reloading of configuration #53

patriksvensson opened this issue Mar 15, 2020 · 0 comments · Fixed by #56
Assignees
@patriksvensson
Labels
feature New feature or request
Milestone
0.12.0

Comments

@patriksvensson
Copy link
Member

Is your feature request related to a problem? Please describe.
If a configuration is changed while Duck is running, the configuration should be reloaded.

Describe the solution you'd like
Reload the configuration if it's changed. If there is an error, do not exit duck but show the error in the log output and a generic error in the UI.
@patriksvensson patriksvensson added the feature New feature or request label Mar 15, 2020
@patriksvensson patriksvensson self-assigned this Mar 16, 2020
patriksvensson added a commit that referenced this issue Mar 19, 2020
@patriksvensson
Add hot reloading of configuration
2e17fd7 
Closes #53
@patriksvensson patriksvensson mentioned this issue Mar 19, 2020
Merged
patriksvensson added a commit that referenced this issue Mar 20, 2020
@patriksvensson
Add hot reload support for configuration
cfc9c67 
Reloads the configuration when it has been changed, and recreates all
collectors and observers. If an error occurs during reload, Duck will
continue to use the old configuration, but write an error to the
console output.

Closes #53
patriksvensson added a commit that referenced this issue Mar 20, 2020
@patriksvensson
Add hot reload support for configuration
61526cb 
Reloads the configuration when it has been changed, and recreates all
collectors and observers. If an error occurs during reload, Duck will
continue to use the old configuration, but write an error to the
console output.

Closes #53
patriksvensson added a commit that referenced this issue Mar 20, 2020
@patriksvensson
Add hot reload support for configuration
8791eae 
Reloads the configuration when it has been changed, and recreates all
collectors and observers. If an error occurs during reload, Duck will
continue to use the old configuration, but write an error to the
console output.

Closes #53
patriksvensson added a commit that referenced this issue Mar 20, 2020
@patriksvensson
Add hot reload support for configuration
5d38a73 
Reloads the configuration when it has been changed, and recreates all
collectors and observers. If an error occurs during reload, Duck will
continue to use the old configuration, but write an error to the
console output.

Closes #53
@patriksvensson patriksvensson added this to the 0.12.0 milestone Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patriksvensson patriksvensson

Labels
feature New feature or request
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Add hot reloading of configuration duckhq/duck
1 participant
@patriksvensson