Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View collectors are not verified at startup #70

Closed
patriksvensson opened this issue Apr 5, 2020 · 0 comments · Fixed by #71
Closed

View collectors are not verified at startup #70

patriksvensson opened this issue Apr 5, 2020 · 0 comments · Fixed by #71
Labels
bug Something isn't working
Milestone
0.13.0

Comments

@patriksvensson
Copy link
Member

Describe the bug
It's possible to have a typo in a view collector id without Duck complaining about it.

Expected behavior
Duck should show an error at startup:

Error: The view 'foo' depends on collector 'bar' which does not exist
@patriksvensson patriksvensson added the bug Something isn't working label Apr 5, 2020
@patriksvensson patriksvensson added this to the 0.13.0 milestone Apr 5, 2020
patriksvensson added a commit that referenced this issue Apr 5, 2020
@patriksvensson
Verify view collectors at startup
d9f20d6 
Closes #70
@patriksvensson patriksvensson mentioned this issue Apr 5, 2020
Merged
patriksvensson added a commit that referenced this issue Apr 5, 2020
@patriksvensson
Merge pull request #71 from duckhq/feature/GH-70
0c9569b 
Verify view collectors at startup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Verify view collectors at startup duckhq/duck
1 participant
@patriksvensson