Add Windows service support #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not block on HTTP server * Add support for installing and uninstalling service Closes #83
gep13
suggested changes
Apr 20, 2020
| @@ -6,7 +6,7 @@ fn main() { | |||
| if env::var("CARGO_FEATURE_EMBEDDED_WEB").is_ok() { | |||
| let dir = Path::new("./web/dist"); | |||
| if !dir.exists() { | |||
| panic!("The UI have not been built."); | |||
| panic!("The UI have not been built"); | |||
There was a problem hiding this comment.
Suggested change
| panic!("The UI have not been built"); | |
| panic!("The UI has not been built"); |
|
@patriksvensson ah, see that you already merged this :-) Nothing major in the review. |
|
@gep13 Not to late to change things. What was your suggestion? |
|
@gep13 Didn’t see your comment for some reason. Will change! Thanks a lot! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83