-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use BODY_LIMIT when creating app #445
Conversation
@matteovivona Does this change make sense? |
I agree with this change. We are running a very large project where our cache size exceeds 50MB, resulting in issues with loading the cache. Could you please review this change? |
@jgoz thank you for your PR! It makes sense. |
@all-contributors please add @jgoz for code and doc |
I've put up a pull request to add @jgoz! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after doc change. Thanks for the PR.
@fox1t @matteovivona The docs already have this variable listed, it just wasn't being used in this spot. |
🎉 This PR is included in version 2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In this PR:
The BODY_LIMIT env variable was being used in the content type parser, but not when creating the fastify app. This meant the practical body limit could not be raised past 50MB.
This PR uses the BODY_LIMIT var for both values.
Checklist:
pnpm lint
locally prior to submission?pnpm build
of your changes locally?pnpm test
of your changes locally?