Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use BODY_LIMIT when creating app #445

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Conversation

jgoz
Copy link
Contributor

@jgoz jgoz commented Oct 10, 2024

In this PR:

  • Bug fix (non-breaking change which fixes an issue)

The BODY_LIMIT env variable was being used in the content type parser, but not when creating the fastify app. This meant the practical body limit could not be raised past 50MB.

This PR uses the BODY_LIMIT var for both values.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
  • Have you commit using Conventional Commits?

@jgoz
Copy link
Contributor Author

jgoz commented Oct 17, 2024

@matteovivona Does this change make sense?

@jakeinflab
Copy link

I agree with this change. We are running a very large project where our cache size exceeds 50MB, resulting in issues with loading the cache. Could you please review this change?
@matteovivona @jgoz

@matteovivona matteovivona self-requested a review November 13, 2024 08:32
@matteovivona
Copy link
Contributor

matteovivona commented Nov 13, 2024

@jgoz thank you for your PR! It makes sense.
Could you also update the documentation with this new variable? I would really appreciate it!

@matteovivona matteovivona added the enhancement New feature or request label Nov 13, 2024
@matteovivona matteovivona self-assigned this Nov 13, 2024
@matteovivona matteovivona requested a review from fox1t November 13, 2024 08:33
@matteovivona
Copy link
Contributor

@all-contributors please add @jgoz for code and doc

Copy link
Contributor

@matteovivona

I've put up a pull request to add @jgoz! 🎉

Copy link
Contributor

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after doc change. Thanks for the PR.

@jgoz
Copy link
Contributor Author

jgoz commented Nov 13, 2024

@fox1t @matteovivona The docs already have this variable listed, it just wasn't being used in this spot.

@kodiakhq kodiakhq bot merged commit 65a80be into ducktors:main Nov 15, 2024
21 checks passed
@matteovivona
Copy link
Contributor

🎉 This PR is included in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants