feat: Use separate Python classes for messages #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenningHolmDE
force-pushed
the
python_classes_for_messages
branch
from
0264c10 to
91ab548
Compare
Pull Request Test Coverage Report for Build 10064745063Details
💛 - Coveralls |
This adds wrapper classes for the messages handled by the codecs' `decode` and `encode` functions. Currently, these classes only provide a dictionary interface through their `from_dict` and `as_dict` methods while this allows for future transitions to a more pythonic interface.
duesee
force-pushed
the
python_classes_for_messages
branch
from
91ab548 to
ba55aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds wrapper classes for the messages handled by the codecs'
decodeandencodefunctions.Currently, these classes only provide a dictionary interface through their
from_dictandas_dictmethods while this allows for future transitions to a more pythonic interface.This closes #559.