-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Nix support #173
Basic Nix support #173
Conversation
Grr... bad luck. First time the CI broke like this. Will look into it. rust-lang/rustup#3709 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, Clement!
I'm a bit torn. On one side, I really want Nix users to feel at home. On the other side, I'm not a (seasoned) Nix user myself and cannot really assess your work. (I have a bit Nix experience but, for example, cannot tell instantly if the flake.lock should be commited, what the compat does, etc.)
Can you say a sentence about each added file? Also, I hope you will help me out when something needs to be reviewed? :-)
Few more questions inline.
I totally understand. I experienced the same feeling when someone sent me a PR for supporting Nix in Himalaya for the first time. Somehow it boosted me to learn about, and finally adopt it, but not everyone is willing to do so. I propose to give you as much information as I can, they you guys decide to accept or not the PR?
Sure, let me do this right now. |
Pull Request Test Coverage Report for Build 9018216518Details
💛 - Coveralls |
@duesee any idea on this mysterious CI error https://github.com/duesee/imap-flow/actions/runs/9001307954/job/24727273648?pr=173? |
Looks like a bug in cargo-deny? I'm on the CI right now. Will merge the just stuff, then come back to this :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, Clement! Also for your patience and great explanations. I did a bit of research myself and start feeling more confident.
Very happy to merge this :-)
I also filed #180.
This PR brings Nix (Flakes) support for development shells. Basically, any Nix user that would like to contribute to the project just needs to
nix-shell
(ornix develop
with flake support) in order to spawn a shell with the Rust environment ready to use.Later steps could be to add
apps
andpackages
to build or test the lib. Ideally from the CI, to benefit from the reproducible build environment Nix proposes.Useful links