Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Nix support #173

Merged
merged 3 commits into from
May 9, 2024
Merged

Basic Nix support #173

merged 3 commits into from
May 9, 2024

Conversation

soywod
Copy link
Contributor

@soywod soywod commented May 7, 2024

This PR brings Nix (Flakes) support for development shells. Basically, any Nix user that would like to contribute to the project just needs to nix-shell (or nix develop with flake support) in order to spawn a shell with the Rust environment ready to use.

Later steps could be to add apps and packages to build or test the lib. Ideally from the CI, to benefit from the reproducible build environment Nix proposes.

Useful links

@soywod soywod changed the title Add Nix support (dev shell only) Basic Nix support May 7, 2024
.gitignore Show resolved Hide resolved
@duesee
Copy link
Owner

duesee commented May 7, 2024

Grr... bad luck. First time the CI broke like this. Will look into it. rust-lang/rustup#3709

rust-toolchain.toml Outdated Show resolved Hide resolved
Copy link
Owner

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, Clement!

I'm a bit torn. On one side, I really want Nix users to feel at home. On the other side, I'm not a (seasoned) Nix user myself and cannot really assess your work. (I have a bit Nix experience but, for example, cannot tell instantly if the flake.lock should be commited, what the compat does, etc.)

Can you say a sentence about each added file? Also, I hope you will help me out when something needs to be reviewed? :-)

Few more questions inline.

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Show resolved Hide resolved
@soywod
Copy link
Contributor Author

soywod commented May 8, 2024

I'm a bit torn. On one side, I really want Nix users to feel at home. On the other side, I'm not a (seasoned) Nix user myself and cannot really assess your work. (I have a bit Nix experience but, for example, cannot tell instantly if the flake.lock should be commited, what the compat does, etc.)

I totally understand. I experienced the same feeling when someone sent me a PR for supporting Nix in Himalaya for the first time. Somehow it boosted me to learn about, and finally adopt it, but not everyone is willing to do so.

I propose to give you as much information as I can, they you guys decide to accept or not the PR?

Can you say a sentence about each added file? Also, I hope you will help me out when something needs to be reviewed? :-)

Sure, let me do this right now.

flake.nix Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented May 8, 2024

Pull Request Test Coverage Report for Build 9018216518

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 64.616%

Totals Coverage Status
Change from base Build 9018208028: 0.1%
Covered Lines: 893
Relevant Lines: 1382

💛 - Coveralls

flake.lock Outdated Show resolved Hide resolved
rust-toolchain.toml Outdated Show resolved Hide resolved
shell.nix Outdated Show resolved Hide resolved
@soywod
Copy link
Contributor Author

soywod commented May 8, 2024

@duesee
Copy link
Owner

duesee commented May 9, 2024

@duesee any idea on this mysterious CI error https://github.com/duesee/imap-flow/actions/runs/9001307954/job/24727273648?pr=173?

Looks like a bug in cargo-deny? I'm on the CI right now. Will merge the just stuff, then come back to this :-)

Copy link
Owner

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, Clement! Also for your patience and great explanations. I did a bit of research myself and start feeling more confident.

Very happy to merge this :-)

I also filed #180.

@duesee duesee merged commit 3468c29 into duesee:main May 9, 2024
8 checks passed
@soywod soywod deleted the nix branch May 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants