Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/requests bug #308

Merged
merged 4 commits into from
May 29, 2023
Merged

Feature/requests bug #308

merged 4 commits into from
May 29, 2023

Conversation

dukeofharen
Copy link
Owner

@dukeofharen dukeofharen commented May 29, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Whenever, for some reason, for a request the request parameters were not saved (e.g. the request paramaters are NULL), the "request overview" endpoint just returns a 500.

What is the new behavior?

A NULL check is performed before returning the results now. The UI can handle the NULL response just well.

Does this introduce a breaking change?

  • Yes
  • No

@dukeofharen dukeofharen merged commit d101835 into master May 29, 2023
@dukeofharen dukeofharen deleted the feature/requests-bug branch December 24, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant