Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in mapping of request in requests API #316

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Conversation

dukeofharen
Copy link
Owner

@dukeofharen dukeofharen commented Jul 7, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The new version of HttPlaceholder couldn't really handle some cases of the old request format, especially when an empty request body was sent.

What is the new behavior?

A simple check was added so it works again.

Does this introduce a breaking change?

  • Yes
  • No

@dukeofharen dukeofharen merged commit 43cef50 into master Jul 7, 2023
@dukeofharen dukeofharen deleted the bug/request-fix branch July 7, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant