Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/fix UI build #327

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Refactoring/fix UI build #327

merged 6 commits into from
Sep 1, 2023

Conversation

dukeofharen
Copy link
Owner

@dukeofharen dukeofharen commented Sep 1, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When the UI was opened (so on http://httplaceholder/ph-ui) the HTML was altered so the root URL was written to it. This result was cached, which means when HttPlaceholder was opened on another machine on the same network, the "old" root URL would still be inserted in the HTML.

What is the new behavior?

  • The UI index.html is not cached anymore.
  • First, when building the UI, the result was just a single HTML file with all CSS and Javascript. I split it again in multiple files, as this is also much easier when manipulating the HTML from the API.

Does this introduce a breaking change?

  • Yes
  • No

@dukeofharen dukeofharen added refactor Improvement of existing code, not introducing new features. bugfix Inconsistencies or issues which will cause a problem for users or implementors. labels Sep 1, 2023
@dukeofharen dukeofharen merged commit 43f9da4 into master Sep 1, 2023
@dukeofharen dukeofharen deleted the refactoring/fix-ui-build branch September 1, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors. refactor Improvement of existing code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant