Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code block should use monospace font #78

Closed
kyoheiu opened this issue May 27, 2023 · 1 comment
Closed

Code block should use monospace font #78

kyoheiu opened this issue May 27, 2023 · 1 comment
Assignees
@dullage
Labels
bug Something isn't working

Comments

@kyoheiu
Copy link

kyoheiu commented May 27, 2023

Idk if this is due to my web browser setting, but I can't see code blocks with monospace.
(FYI, e.g. code blocks in GitHub's README come with monospace)

Example:
MSRV-flatnotes

It'd be better to use monospace in such blocks.
@dullage dullage added the bug Something isn't working label May 29, 2023
@dullage dullage self-assigned this May 29, 2023
@dullage
Copy link
Owner

dullage commented May 29, 2023

I left the font for the code blocks as styled by the Toast UI Editor.

font-family: Consolas,Courier,Apple SD 산돌고딕 Neo,-apple-system,Lucida Grande,Apple SD Gothic Neo,맑은 고딕,Malgun Gothic,Segoe UI,돋움,dotum,sans-serif;

The first 2 (Consolas and Courier) are monospaced but many of the fallbacks are not. Presumably, you don't have Consolas or Courier available and so are ending up with one of the others. I'll update the font-family in an upcoming release which should solve this.

@dullage dullage closed this as completed in 689e0e3 Jun 4, 2023
Gedulis12 pushed a commit to Gedulis12/flatnotes that referenced this issue Aug 7, 2023
@dullage @Gedulis12
Override default font-family for code blocks to fix dullage#78
f9af501
Gedulis12 added a commit to Gedulis12/flatnotes that referenced this issue Aug 7, 2023
@Gedulis12
Revert "Override default font-family for code blocks to fix dullage#78"
3771d8d 
This reverts commit f9af501.
Gedulis12 added a commit to Gedulis12/flatnotes that referenced this issue Aug 7, 2023
@Gedulis12
Revert "Override default font-family for code blocks to fix dullage#78"
d09ce40 
This reverts commit f9af501.
Gedulis12 added a commit to Gedulis12/flatnotes that referenced this issue Aug 7, 2023
@Gedulis12
Revert "Master" (#3)
44e3fc4 
* Revert "3.2.2"

This reverts commit 6b601fe.

* Revert "Corrected group variable typo in entrypoint.sh"

This reverts commit 3cb86a1.

* Revert "Updated README to resolve dullage#100"

This reverts commit 05fc652.

* Revert "3.2.1"

This reverts commit 4651830.

* Revert "Prevent recently modified from showing in read_only mode"

This reverts commit a3aa2a8.

* Revert "Various config settings are no longer required in read_only mode"

This reverts commit 3535978.

* Revert "3.2.0"

This reverts commit ee328bc.

* Revert "Updated README"

This reverts commit 253155a.

* Revert "Updated README"

This reverts commit b731a1c.

* Revert "Implement read-only mode"

This reverts commit 608a414.

* Revert "Fix theme issues. Resolves dullage#94."

This reverts commit 20725e8.

* Revert "Added _edit_only auth types"

This reverts commit 0e2a3f5.

* Revert "Remove async from path functions"

This reverts commit 161978c.

* Revert "3.1.1"

This reverts commit 8881755.

* Revert "Fix issue clicking links in unordered lists"

This reverts commit c3a073d.

* Revert "Disable checkboxes in view mode. Resolves dullage#81."

This reverts commit 1548b66.

* Revert "Formatting changes only"

This reverts commit 3aeb903.

* Revert "Assign ID to headers with CustomHTMLRenderer (dullage#84)"

This reverts commit 26e6b56.

* Revert "Ensure root knows when note title changes. Fixes dullage#82."

This reverts commit 851c640.

* Revert "Override default font-family for code blocks to fix dullage#78"

This reverts commit f9af501.

* Revert "Added VOLUME and EXPOSE keywords to Dockerfile"

This reverts commit 44e2b7a.

* Revert "3.1.0"

This reverts commit 8aa641c.

* Revert "Enabled extended autolinks"

This reverts commit 4b477f6.

* Revert "Ignore markdown codeblocks for tags (dullage#66)"

This reverts commit f7d206c.

* Revert "Fix get_tags method"

This reverts commit 99c2909.

* Revert "Updated README"

This reverts commit 39d54fc.

* Revert "3.0.3"

This reverts commit 5acf117.

* Revert "Secret key is now printed to console if using TOTP allowing for manual entry"

This reverts commit 5b74804.

* Revert "3.0.2"

This reverts commit 15d93af.

* Revert "Table headers in WYSIWYG editor now honour theme color"

This reverts commit 050b6d8.

* Revert "PR comments"

This reverts commit efdf4bf.

* Revert "Update site.webmanifest"

This reverts commit 285ab5d.
Gedulis12 pushed a commit to Gedulis12/flatnotes that referenced this issue Aug 7, 2023
@dullage @Gedulis12
Override default font-family for code blocks to fix dullage#78
15bea9b
Gedulis12 pushed a commit to Gedulis12/flatnotes that referenced this issue Aug 7, 2023
@dullage @Gedulis12
Combine commits
ed798c0 
3.2.2

Revert "Corrected group variable typo in entrypoint.sh"

This reverts commit 3cb86a1.

Revert "Updated README to resolve dullage#100"

This reverts commit 05fc652.

Revert "3.2.1"

This reverts commit 4651830.

Revert "Prevent recently modified from showing in read_only mode"

This reverts commit a3aa2a8.

Revert "Various config settings are no longer required in read_only mode"

This reverts commit 3535978.

Revert "3.2.0"

This reverts commit ee328bc.

Revert "Updated README"

This reverts commit 253155a.

Revert "Updated README"

This reverts commit b731a1c.

Revert "Implement read-only mode"

This reverts commit 608a414.

Revert "Fix theme issues. Resolves dullage#94."

This reverts commit 20725e8.

Revert "Added _edit_only auth types"

This reverts commit 0e2a3f5.

Revert "Remove async from path functions"

This reverts commit 161978c.

Revert "3.1.1"

This reverts commit 8881755.

Revert "Fix issue clicking links in unordered lists"

This reverts commit c3a073d.

Revert "Disable checkboxes in view mode. Resolves dullage#81."

This reverts commit 1548b66.

Revert "Formatting changes only"

This reverts commit 3aeb903.

Revert "Assign ID to headers with CustomHTMLRenderer (dullage#84)"

This reverts commit 26e6b56.

Revert "Ensure root knows when note title changes. Fixes dullage#82."

This reverts commit 851c640.

Revert "Override default font-family for code blocks to fix dullage#78"

This reverts commit f9af501.

Revert "Added VOLUME and EXPOSE keywords to Dockerfile"

This reverts commit 44e2b7a.

Revert "3.1.0"

This reverts commit 8aa641c.

Revert "Enabled extended autolinks"

This reverts commit 4b477f6.

Revert "Ignore markdown codeblocks for tags (dullage#66)"

This reverts commit f7d206c.

Revert "Fix get_tags method"

This reverts commit 99c2909.

Revert "Updated README"

This reverts commit 39d54fc.

Revert "3.0.3"

This reverts commit 5acf117.

Revert "Secret key is now printed to console if using TOTP allowing for manual entry"

This reverts commit 5b74804.

Revert "3.0.2"

This reverts commit 15d93af.

Revert "Table headers in WYSIWYG editor now honour theme color"

This reverts commit 050b6d8.

Revert "PR comments"

This reverts commit efdf4bf.

Revert "Update site.webmanifest"

This reverts commit 285ab5d.

Update site.webmanifest

PR comments

Table headers in WYSIWYG editor now honour theme color

3.0.2

Secret key is now printed to console if using TOTP allowing for manual entry

3.0.3

Updated README

Fix get_tags method

Ignore markdown codeblocks for tags (dullage#66)

* Ignore markdown codeblocks for tags

* Changed `content_ex_tags` to use `content` instead of `content_ex_codeblock`

* Bumped `INDEX_SCHEMA_VERSION`

Enabled extended autolinks

3.1.0

Added VOLUME and EXPOSE keywords to Dockerfile

Override default font-family for code blocks to fix dullage#78

Ensure root knows when note title changes. Fixes dullage#82.

Assign ID to headers with CustomHTMLRenderer (dullage#84)

Formatting changes only

Disable checkboxes in view mode. Resolves dullage#81.

Fix issue clicking links in unordered lists

3.1.1

Remove async from path functions

Added _edit_only auth types

Fix theme issues. Resolves dullage#94.

Implement read-only mode

Updated README

Updated README

3.2.0

Various config settings are no longer required in read_only mode

Prevent recently modified from showing in read_only mode

3.2.1

Updated README to resolve dullage#100

Corrected group variable typo in entrypoint.sh

3.2.2

Revert "Master" (#3)

* Revert "3.2.2"

This reverts commit 6b601fe.

* Revert "Corrected group variable typo in entrypoint.sh"

This reverts commit 3cb86a1.

* Revert "Updated README to resolve dullage#100"

This reverts commit 05fc652.

* Revert "3.2.1"

This reverts commit 4651830.

* Revert "Prevent recently modified from showing in read_only mode"

This reverts commit a3aa2a8.

* Revert "Various config settings are no longer required in read_only mode"

This reverts commit 3535978.

* Revert "3.2.0"

This reverts commit ee328bc.

* Revert "Updated README"

This reverts commit 253155a.

* Revert "Updated README"

This reverts commit b731a1c.

* Revert "Implement read-only mode"

This reverts commit 608a414.

* Revert "Fix theme issues. Resolves dullage#94."

This reverts commit 20725e8.

* Revert "Added _edit_only auth types"

This reverts commit 0e2a3f5.

* Revert "Remove async from path functions"

This reverts commit 161978c.

* Revert "3.1.1"

This reverts commit 8881755.

* Revert "Fix issue clicking links in unordered lists"

This reverts commit c3a073d.

* Revert "Disable checkboxes in view mode. Resolves dullage#81."

This reverts commit 1548b66.

* Revert "Formatting changes only"

This reverts commit 3aeb903.

* Revert "Assign ID to headers with CustomHTMLRenderer (dullage#84)"

This reverts commit 26e6b56.

* Revert "Ensure root knows when note title changes. Fixes dullage#82."

This reverts commit 851c640.

* Revert "Override default font-family for code blocks to fix dullage#78"

This reverts commit f9af501.

* Revert "Added VOLUME and EXPOSE keywords to Dockerfile"

This reverts commit 44e2b7a.

* Revert "3.1.0"

This reverts commit 8aa641c.

* Revert "Enabled extended autolinks"

This reverts commit 4b477f6.

* Revert "Ignore markdown codeblocks for tags (dullage#66)"

This reverts commit f7d206c.

* Revert "Fix get_tags method"

This reverts commit 99c2909.

* Revert "Updated README"

This reverts commit 39d54fc.

* Revert "3.0.3"

This reverts commit 5acf117.

* Revert "Secret key is now printed to console if using TOTP allowing for manual entry"

This reverts commit 5b74804.

* Revert "3.0.2"

This reverts commit 15d93af.

* Revert "Table headers in WYSIWYG editor now honour theme color"

This reverts commit 050b6d8.

* Revert "PR comments"

This reverts commit efdf4bf.

* Revert "Update site.webmanifest"

This reverts commit 285ab5d.

Revert "Revert "Master" (#3)"

This reverts commit 44e3fc4.
Gedulis12 added a commit to Gedulis12/flatnotes that referenced this issue Aug 7, 2023
@Gedulis12 @abe6
@dullage @adullage @elmodor @pbogre
Master (#5)
5459a53 
* Update site.webmanifest

* PR comments

* Table headers in WYSIWYG editor now honour theme color

* 3.0.2

* Secret key is now printed to console if using TOTP allowing for manual entry

* 3.0.3

* Updated README

* Fix get_tags method

* Ignore markdown codeblocks for tags (dullage#66)

* Ignore markdown codeblocks for tags

* Changed `content_ex_tags` to use `content` instead of `content_ex_codeblock`

* Bumped `INDEX_SCHEMA_VERSION`

* Enabled extended autolinks

* 3.1.0

* Added VOLUME and EXPOSE keywords to Dockerfile

* Override default font-family for code blocks to fix dullage#78

* Ensure root knows when note title changes. Fixes dullage#82.

* Assign ID to headers with CustomHTMLRenderer (dullage#84)

* Formatting changes only

* Disable checkboxes in view mode. Resolves dullage#81.

* Fix issue clicking links in unordered lists

* 3.1.1

* Remove async from path functions

* Added _edit_only auth types

* Fix theme issues. Resolves dullage#94.

* Implement read-only mode

* Updated README

* Updated README

* 3.2.0

* Various config settings are no longer required in read_only mode

* Prevent recently modified from showing in read_only mode

* 3.2.1

* Updated README to resolve dullage#100

* Corrected group variable typo in entrypoint.sh

* 3.2.2

---------

Co-authored-by: Abraham Elias <46859202+abe6@users.noreply.github.com>
Co-authored-by: Abraham Elias <abraham@manjaro>
Co-authored-by: Adam Dullage <adam@dullage.com>
Co-authored-by: Adam Dullage <adam.dullage@itris.co.uk>
Co-authored-by: elmodor <elmodor@users.noreply.github.com>
Co-authored-by: Pietro Bonaldo Gregori <45976792+pbogre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dullage dullage

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dullage @kyoheiu