Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pin notes #210

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

michaelkennethdavid
Copy link
Contributor

@michaelkennethdavid michaelkennethdavid commented Jun 29, 2024

This pull request adds the ability to pin notes within the application. Notes can now be pinned by adding #pinned anywhere in the note content.

  • Added functionality to mark notes as pinned using #pinned.
  • Optionally display pinned notes on the home page by setting FLATNOTES_HIDE_PINNED_NOTES to false. Pinned notes are hidden by default on the home page.
  • View all your pinned notes via the menu button: Menu -> Pinned Notes

recent-pinned-home-page

image

Default home page / FLATNOTES_HIDE_PINNED_NOTES: "true"
image

@dullage
Copy link
Owner

dullage commented Jul 1, 2024

Thanks for the PR @michaelkennethdavid.

There's a lot to like here and in general, I like the proposed change. It does, however, commit flatnotes down a particular route when it comes to things like pinning and so I need to mull it over first. There's also a couple of bits I'm not entirely comfortable with, namely:

  • The increased "busyness" of the home page.
  • The duel calls to the API on load.

I'll come back to you on this.

@michaelkennethdavid
Copy link
Contributor Author

I understand. Let me know if I need to change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants