Fix API being inaccessible when using FLATNOTES_AUTH_TYPE=none #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When FLATNOTES_AUTH_TYPE=none, the API becomes inaccessible as a format check on the API token is done and is failed before the authentication type is checked. This commit places the auth type check after the check for the token format as an attempt to fix this.
|
Thanks for the contribution. This is certainly a drawback that I'd like to fix. As it's related to authentication, I'd like to spend some time digging into the FastAPI docs to get a better understanding of the change before I merge it. I'll get to this as soon as I get a chance. |
|
I took a look into this and unfortunately, this approach didn't work out. I was able to find a solution though which is now available in the |
|
Awesome - thanks for taking a look and sorting it in the end :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
FLATNOTES_AUTH_TYPE=none, the API becomes inaccessible as a format check on the API token is done and is failed before the authentication type is checked.This commit attempts to fix that by moving the auth type check after the check for the token format.
Full disclaimer that I don't really know what I'm doing with FastAPI - this feels like a bit of a bodge. The context behind this PR is that I use a 3rd-party authentication system on top of Flatnotes and I can't use the API.
Cheers :)