Fix executing a query with parameters #3
Conversation
| @@ -5,6 +5,10 @@ import ( | |||
| "strings" | |||
| ) | |||
|
|
|||
| type ExecuteRequest struct { | |||
| QueryParameters map[string]string `json:"query_parameters,omitempty"` | |||
There was a problem hiding this comment.
map[string]any
should be any, I don't know of a better way of saying:
it is either string or a float64 or an integer, maybe @diegoximenes or @jmsgu know..
There was a problem hiding this comment.
For (int | string) this can be useful: https://pkg.go.dev/k8s.io/apimachinery/pkg/util/intstr#IntOrString.
I am not sure if with the generics support from go 1.18 something nice appeared related to this kind of issue, I haven't used generics on golang yet.
Regarding float, usually I discourage using it for types on API interfaces, unless it is really necessary, due to round trip issues.
Check a little about k8s APIs handling numbers with Quantity (https://pkg.go.dev/k8s.io/apimachinery/pkg/api/resource#Quantity) by the way: kubernetes-sigs/controller-tools#245
There was a problem hiding this comment.
We have to support float, since just restricting parameters to int is not really desirable. I'll make it any for now and we can see about using maybe only string in the future and doing a conversion on the duneapi side, or even QES
No description provided.