Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate balances_ethereum_erc20_day #4074

Closed
wants to merge 46 commits into from

Conversation

lajarre
Copy link

@lajarre lajarre commented Aug 14, 2023

Summary of changes

  • Migrating balances_ethereum_erc20_day and balances_ethereum_erc20_hour and related files to DuneSQL and update their related schema
  • tests/balances/ethereum/balances_ethereum_erc20_day_assert_nonnegative.sql: relax test by rounding to 0 digits. This might be improved if necessary.
  • Non-compliant tokens check: relaxed to < 1100, from < 550. This seems reasonable as the test itself was reporting a number of reported non-compliant tokens slightly above 1000.

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lajarre
Copy link
Author

lajarre commented Aug 14, 2023

I have read the CLA Document and I hereby sign the CLA

@lajarre
Copy link
Author

lajarre commented Aug 14, 2023

recheck

@dune-eng
Copy link

Workflow run id 5857597425 approved.

@dune-eng
Copy link

Workflow run id 5857597619 approved.

github-actions bot added a commit that referenced this pull request Aug 14, 2023
@lajarre lajarre force-pushed the migrate-balances-erc20 branch from cf41ebb to f487533 Compare August 14, 2023 15:50
@dune-eng
Copy link

Workflow run id 5857812523 approved.

@dune-eng
Copy link

Workflow run id 5857812847 approved.

@lajarre lajarre force-pushed the migrate-balances-erc20 branch from f487533 to a346ddd Compare August 14, 2023 16:56
@dune-eng
Copy link

Workflow run id 5858443906 approved.

@dune-eng
Copy link

Workflow run id 5858444006 approved.

@dune-eng
Copy link

Workflow run id 5858537123 approved.

@dune-eng
Copy link

Workflow run id 5858537347 approved.

@dune-eng
Copy link

Workflow run id 5860196812 approved.

@dune-eng
Copy link

Workflow run id 5860196735 approved.

@dune-eng
Copy link

Workflow run id 5860213136 approved.

@dune-eng
Copy link

Workflow run id 5860213129 approved.

@lajarre lajarre force-pushed the migrate-balances-erc20 branch from f84ae21 to 1d5bb78 Compare August 14, 2023 23:02
@dune-eng
Copy link

Workflow run id 5861527348 approved.

@dune-eng
Copy link

Workflow run id 5861527268 approved.

@dune-eng
Copy link

Workflow run id 5861671236 approved.

@dune-eng
Copy link

Workflow run id 5861671127 approved.

@dune-eng
Copy link

Workflow run id 5865333975 approved.

@dune-eng
Copy link

Workflow run id 5865333902 approved.

@dune-eng
Copy link

Workflow run id 5865425151 approved.

@dune-eng
Copy link

Workflow run id 5865425266 approved.

@lajarre lajarre force-pushed the migrate-balances-erc20 branch from 14de66b to ecf9659 Compare August 15, 2023 09:17
@dune-eng
Copy link

Workflow run id 5865577782 approved.

@dune-eng
Copy link

Workflow run id 5865578162 approved.

@lajarre lajarre force-pushed the migrate-balances-erc20 branch from 83a7621 to 6e7a00f Compare September 28, 2023 14:56
@dune-eng
Copy link

Workflow run id 6340645513 approved.

@dune-eng
Copy link

Workflow run id 6340645942 approved.

@jeff-dude jeff-dude assigned aalan3 and unassigned antonio-mendes Oct 9, 2023
@jeff-dude jeff-dude removed the ready-for-review this PR development is complete, please review label Oct 9, 2023
@lajarre lajarre mentioned this pull request Oct 9, 2023
6 tasks
@jeff-dude
Copy link
Member

thank you for the patience, now that the spellbook migration is complete, as we attempt to rebuild transfers & balances spells on the dunesql engine 🙏

we will close this PR now, as the work on this set of sector spells can be tracked in the following locations:
#4521
#4523
#4633
#4698

@jeff-dude jeff-dude closed this Nov 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants