Erc20 transfers macro #4522
Closed
Erc20 transfers macro #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aalan3 it's casted to double because uint256 can't be negative, I think you'd have to cast to INT256? Which I think wasn't working as well but id on't remember why.. |
|
@henrystats have a look at the current version, this is now using |
|
awesome, looks good to me! |
lajarre
reviewed
Oct 9, 2023
| contract_address as token_address, | ||
| CAST(value as double) as amount_raw | ||
| FROM | ||
| try_cast(value as int256) as amount_raw |
There was a problem hiding this comment.
It seems to me that this would produce some data loss on some potentially relevant pieces of data. Are we confident these are not relevant cases?
For example, a treasury address receiving more than half the token supply of a token which total supply is 2^256-1 would be filtered out by the try_cast here.
See my comment there: #4521 (comment)
|
(assuming this is old, in favor of #4633, closing this now) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #4521.
I've updated the following:
incremental_predicatemacroamount_rawis no longer converted to double - it should beuint256