-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token balances ethereum #4640
Merged
Merged
Token balances ethereum #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belen-pruvost
force-pushed
the
token_balances_ethereum
branch
2 times, most recently
from
October 23, 2023 13:43
65935ee
to
4b63c2d
Compare
belen-pruvost
force-pushed
the
token_transfers
branch
from
October 23, 2023 13:44
d6764d1
to
15c8fe1
Compare
belen-pruvost
force-pushed
the
token_balances_ethereum
branch
from
October 23, 2023 13:45
4b63c2d
to
04ebaea
Compare
belen-pruvost
force-pushed
the
token_transfers
branch
from
October 24, 2023 07:52
15c8fe1
to
511ea96
Compare
belen-pruvost
force-pushed
the
token_balances_ethereum
branch
from
October 24, 2023 07:52
8be4f90
to
e82a5e7
Compare
aalan3
force-pushed
the
token_transfers
branch
from
October 25, 2023 10:15
511ea96
to
93c5b9e
Compare
aalan3
force-pushed
the
token_balances_ethereum
branch
from
October 26, 2023 09:40
e82a5e7
to
01a6ce4
Compare
aalan3
force-pushed
the
token_transfers
branch
from
November 7, 2023 11:16
3f2ce50
to
748e7db
Compare
This reverts commit 8a6d0f1.
aalan3
force-pushed
the
token_balances_ethereum
branch
from
November 8, 2023 12:54
95a735c
to
e056946
Compare
This is ready for reviews but native balances are not correct |
jeff-dude
added
in review
Assignee is currently reviewing the PR
and removed
WIP
work in progress
labels
Nov 14, 2023
are you good with my commits? it timed out, as expected. we can still look to merge tomorrow, if you are good with the current state. |
Yeah thank you! I was going to do transfers in a separate PR but might as well do it here. Tests are also a good idea. |
jeff-dude
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be considered a beta version of token balances so this is not yet exposed. The tables are split by
native
anderc20
tokens because doing everything together uses too much memory in Trino, these are considered intermediary tables and are unioned together in the main tablebalances_base
.Some notes:
sum()
because there's no way of catching overflows that happen inside of a aggregation at the moment