base chain dex & dex-agg routers #4758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update socialtokens.sql
|
Workflow run id 6819093083 approved. |
|
Workflow run id 6819093267 approved. |
jeff-dude
requested changes
Nov 10, 2023
| @@ -0,0 +1,30 @@ | |||
| {{config(alias = 'dex', | |||
There was a problem hiding this comment.
please add schema config in the model directly
There was a problem hiding this comment.
i added a separate schema file again here. lmk if any changes needed
jeff-dude
added
WIP
|
Workflow run id 6855680293 approved. |
|
Workflow run id 6855680510 approved. |
|
Workflow run id 6855785259 approved. |
|
Workflow run id 6855785057 approved. |
jeff-dude
reviewed
Nov 13, 2023
| @@ -0,0 +1,29 @@ | |||
| {{ config( | |||
| schema = 'addresses_base', | |||
There was a problem hiding this comment.
i communicated that poorly, but i meant to add schema config here (i pushed a commit)
that actually worked out though, cause adding schema yml file was good too 🙂
jeff-dude
added
ready-for-merging
and removed
WIP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels for dex & dex-agg addresses