Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dodo to dex.trades_beta #5049

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

tomfutago
Copy link
Contributor

@tomfutago tomfutago commented Dec 23, 2023

linked to #4759

@dune-eng
Copy link

Workflow run id 7309376613 approved.

@dune-eng
Copy link

Workflow run id 7309376690 approved.

@dune-eng
Copy link

Workflow run id 7314031997 approved.

@dune-eng
Copy link

Workflow run id 7314202899 approved.

@dune-eng
Copy link

Workflow run id 7314202927 approved.

@tomfutago tomfutago marked this pull request as ready for review December 24, 2023 11:19
@Hosuke Hosuke self-assigned this Dec 26, 2023
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @tomfutago
cc. dodo data team @owen05

dodo_*.base_trades checking

@Hosuke Hosuke added dbt: dex covers the DEX dbt subproject ready-for-final-review labels Jan 2, 2024
@Hosuke Hosuke removed their assignment Jan 2, 2024
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work on this one with extra complexity!

@jeff-dude jeff-dude merged commit cced2ae into duneanalytics:main Jan 2, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants