Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integral to dex.trades_beta #5057

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Add integral to dex.trades_beta #5057

merged 4 commits into from
Jan 2, 2024

Conversation

tomfutago
Copy link
Contributor

linked to #4759

@dune-eng
Copy link

Workflow run id 7337628790 approved.

@dune-eng
Copy link

Workflow run id 7337628751 approved.

@tomfutago tomfutago marked this pull request as ready for review December 27, 2023 11:04
@Hosuke Hosuke self-assigned this Dec 28, 2023
Hosuke
Hosuke approved these changes Jan 1, 2024
View reviewed changes
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @tomfutago

Sample integral_ethereum_base_trades
Sample integral_arbitrum_base_trades

@Hosuke Hosuke added dbt: dex covers the DEX dbt subproject ready-for-final-review labels Jan 1, 2024
@Hosuke Hosuke removed their assignment Jan 1, 2024
jeff-dude
jeff-dude approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you as always!

@jeff-dude jeff-dude self-assigned this Jan 2, 2024
@jeff-dude jeff-dude merged commit 8280cec into duneanalytics:main Jan 2, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

@Hosuke Hosuke Hosuke approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomfutago @dune-eng @Hosuke @jeff-dude