Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix denormalizing enums #114

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Fix denormalizing enums #114

merged 1 commit into from
Jun 15, 2022

Conversation

norkunas
Copy link
Contributor

Closes #113

@norkunas norkunas force-pushed the fix-denormalizing-enums branch 3 times, most recently from e398a6c to d982d55 Compare March 10, 2022 12:50
@norkunas norkunas force-pushed the fix-denormalizing-enums branch from d982d55 to 08ddbc8 Compare March 11, 2022 04:52
@norkunas
Copy link
Contributor Author

norkunas commented Apr 1, 2022

Will this be merged? :)

@norkunas
Copy link
Contributor Author

friendly ping @dunglas :)

dunglas
dunglas requested changes Jun 15, 2022
View reviewed changes
Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also apply the StyleCI patch please?

src/Bundle/DependencyInjection/DunglasDoctrineJsonOdmExtension.php Outdated Show resolved Hide resolved
@norkunas norkunas force-pushed the fix-denormalizing-enums branch from 08ddbc8 to c2609b0 Compare June 15, 2022 15:25
@norkunas
Copy link
Contributor Author

Could you also apply the StyleCI patch please?

I'm not sure how, because the error I see:

Syntax Error - tests/Fixtures/TestBundle/Enum/InputMode.php
Unexpected identifier "InputMode" on line 12.

so to me it looks like that it doesn't support enum

@dunglas dunglas merged commit 5403359 into dunglas:main Jun 15, 2022
@dunglas
Copy link
Owner

dunglas commented Jun 15, 2022

Thanks!

@norkunas norkunas deleted the fix-denormalizing-enums branch June 16, 2022 03:04
@darthf1
Copy link

darthf1 commented Sep 8, 2022

Would it be possible to push a new release with this change? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum support
3 participants
@norkunas @dunglas @darthf1