Add Uid normalizer #131
Merged
Add Uid normalizer #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dunglas Do you know how i can handle the installation for symfony/uid only for php >= 7.2 ? Thanks 🙏 |
|
@dunglas Can you help on this ? |
|
You can either bump the minimum PHP version (PHP <8 isn't maintained anymore) or install |
|
Are you OK with removing compatibility with < 8 ? |
|
@dunglas With symfony 7.0 release, the CI was broken, are you OK to revert 7.0 support now ? I will send a new PR with a complete support |
|
Yes, no problem |
|
The PR is ready, ok for merge ? |
dunglas
approved these changes
Nov 29, 2023
|
Thank you!! |
|
@amenophis were you planning to do that new PR (bringing back SF7 support) or? |
|
@back-2-95 In progress here: #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the Symfony Uid normalizer