Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming DEBUG env var #57

Closed
withinboredom opened this issue Oct 22, 2022 · 1 comment · Fixed by #79
Closed

Consider renaming DEBUG env var #57

withinboredom opened this issue Oct 22, 2022 · 1 comment · Fixed by #79
Labels
enhancement New feature or request

Comments

@withinboredom
Copy link
Collaborator

In the built-in Caddyfile, there is a built-in DEBUG env var injected. This is quite generic and may conflict with other frameworks or applications. Perhaps we should call it FRANKENPHP_DEBUG?
@dunglas
Copy link
Owner

dunglas commented Oct 22, 2022

We're already using the same variable to enable the debug mode of Caddy in Mercure, Symfony Docker and API Platform. Maybe could we use CADDY_DEBUG everywhere?

@dunglas dunglas added the enhancement New feature or request label Oct 23, 2022
@chalasr chalasr mentioned this issue Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rename DEBUG env var to CADDY_DEBUG chalasr/frankenphp
2 participants
@dunglas @withinboredom