Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename DEBUG env var to CADDY_DEBUG #79

Merged
merged 1 commit into from
Nov 3, 2022
Merged

feat: rename DEBUG env var to CADDY_DEBUG #79

merged 1 commit into from
Nov 3, 2022

Conversation

chalasr
Copy link
Contributor

@chalasr chalasr commented Oct 31, 2022

Fixes #57

dunglas
dunglas approved these changes Oct 31, 2022
View reviewed changes
Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you open the same PR on Symfony Docker and API Platform, please?

@chalasr
Copy link
Contributor Author

chalasr commented Oct 31, 2022

Are we sure we won't want to reuse this flag at some point for other purposes (non caddy related)? Otherwise FRANKENPHP_DEBUG might be more future proof. Just wondering

Could you open the same PR on Symfony Docker and API Platform, please?

Sure!

@dunglas
Copy link
Owner

dunglas commented Nov 1, 2022

As this env var contains a string that will be injected in Caddyfile, I think it's good as-is.

This was referenced Nov 1, 2022
Merged
Merged
@chalasr
Copy link
Contributor Author

chalasr commented Nov 1, 2022

Alright then. Companion PRs: api-platform/api-platform#2313, dunglas/symfony-docker#31

@dunglas dunglas merged commit bfb0b17 into dunglas:main Nov 3, 2022
@dunglas
Copy link
Owner

dunglas commented Nov 3, 2022

Thanks @chalasr!

@chalasr chalasr deleted the feat/rename-caddy-debug branch November 3, 2022 12:37
@chalasr chalasr restored the feat/rename-caddy-debug branch November 3, 2022 12:37
@chalasr chalasr deleted the feat/rename-caddy-debug branch November 3, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming DEBUG env var
3 participants
@chalasr @dunglas @maxhelias