Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add performance docs #1004

Merged
merged 15 commits into from
Aug 27, 2024
Merged

docs: add performance docs #1004

merged 15 commits into from
Aug 27, 2024

Conversation

dunglas
Copy link
Owner

@dunglas dunglas commented Aug 26, 2024

I tried to compile what we know to improve FrankenPHP's performance, but I'm sure @withinboredom has other ideas!

docs/performance.md Outdated Show resolved Hide resolved
docs/performance.md Outdated Show resolved Hide resolved
dunglas and others added 2 commits August 26, 2024 22:23
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
docs/performance.md Outdated Show resolved Hide resolved
docs/performance.md Outdated Show resolved Hide resolved
docs/performance.md Outdated Show resolved Hide resolved
docs/performance.md Outdated Show resolved Hide resolved
docs/performance.md Outdated Show resolved Hide resolved
dunglas and others added 8 commits August 26, 2024 22:23
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
docs/performance.md Outdated Show resolved Hide resolved
@dunglas dunglas merged commit 47257ec into main Aug 27, 2024
44 checks passed
@dunglas dunglas deleted the docs/performance branch August 27, 2024 09:45
@bendavies
Copy link

hey @dunglas thanks for this!

I was searching around for how to configure GOMEMLIMIT as the Performance page in the docs is very light on detail.

See here for a comment from @withinboredom of a good approximation:
#786 (comment)

If the above approximation is correct, it would be great to update the docs.

Thanks!

@bendavies
Copy link

possibly more info on a suggested value in this discussion
#941

@bendavies
Copy link

bendavies commented Sep 11, 2024

Also, in these docs, it would be great to include some help on configuring number of threads and workers calculated from:

  1. total memory available
  2. the value of php's memory_limit.
  3. etc...

configuring number of threads, workers and GOMEMLIMIT seems a bit of guess work from a new user's point of view (at least my own), and I'd love some help on calculating some good starting points.

@bendavies bendavies mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants