Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose PHP version #102

Merged
merged 1 commit into from
Nov 12, 2022
Merged

feat: expose PHP version #102

merged 1 commit into from
Nov 12, 2022

Conversation

dunglas
Copy link
Owner

@dunglas dunglas commented Nov 11, 2022

Add a new function to retrieve the PHP version and display the used version in the logs of the Caddy module.

Copy link
Collaborator

@withinboredom withinboredom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a bit out of scope, but is there any way to include a build number, git hash, or random gibberish of FrankenPHP as well? There's been a couple of times when I haven't been able to easily determine that I'm running the "latest and greatest" of FrankenPHP.

@dunglas
Copy link
Owner Author

dunglas commented Nov 12, 2022

We should use ldflags to do that. If we manage to switch to GoReleaser (#82), we could use its native feature: https://goreleaser.com/cookbooks/using-main.version

@dunglas dunglas merged commit 6a6dda5 into main Nov 12, 2022
@dunglas dunglas deleted the feat/version branch November 12, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants