Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom Caddy modules to the static binary #1210

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

dunglas
Copy link
Owner

@dunglas dunglas commented Nov 26, 2024

Add custom Caddy modules to static binaries.

Example with Souin, Mercure and Vulcain:

XCADDY_ARGS="--with github.com/darkweak/souin/plugins/caddy --with github.com/dunglas/mercure/caddy --with github.com/dunglas/vulcain/caddy"  \
./build-static.sh

Closes #1208, closes #982, closes #591.

TODO:

  • docs

@dunglas dunglas force-pushed the feat/static-custom-caddy-modules branch from 4aa69d3 to 8cabad9 Compare November 27, 2024 10:02
@dunglas
Copy link
Owner Author

dunglas commented Nov 27, 2024

The error in the CI is super weird

@vittodevit
Copy link

Tried testing the branch locally but the error is exactly the same.
It seems to crash at one of the last steps of the static-build.sh file when it's defining the environment variables?
image

@withinboredom
Copy link
Collaborator

How big is the environment + command? It looks like what you used to get when your total command length + env exceeded the maximum back in the day.

@vittodevit
Copy link

Ok, i found the time to do a couple more tests.
Without using the container, i ran directly the build-static.sh file and this is where it crashes: https://dpaste.com/6NVEGLWN2
The env i used is this: https://dpaste.com/HTVXLJM84
Running it without the env gives the exact same error.

@dunglas dunglas force-pushed the feat/static-custom-caddy-modules branch from 8cabad9 to 25b1fcd Compare December 18, 2024 09:01
@dunglas dunglas force-pushed the feat/static-custom-caddy-modules branch from 0b27c45 to 3cc2566 Compare December 18, 2024 16:21
@dunglas
Copy link
Owner Author

dunglas commented Dec 18, 2024

This seems to work now, but I'm not sure why...

@dunglas dunglas merged commit d276032 into main Dec 18, 2024
54 checks passed
@dunglas dunglas deleted the feat/static-custom-caddy-modules branch December 18, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants