-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker buildx bake - The Sequel #133
Conversation
- name: Run tests | ||
run: | | ||
docker load -i /tmp/.builder.tar | ||
docker run --rm frankenphp:${{ github.sha }}-builder "go test -a -v" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to continue running the tests somewhere in the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is just that I need help with this one.
WORKDIR /go/src/app | ||
|
||
COPY go.mod go.sum ./ | ||
RUN go mod graph | awk '{if ($1 !~ "@") print $2}' | xargs go get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment explaining why it's necessary please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate file or what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what it's doing :D
@back-2-95 I would really like to get this PR merged! Is there anything I can do to help? |
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
4601f31
to
c5b035a
Compare
I rebased your branch and fixed and issue with the Dockerfile versions. |
bullseye
andalpine 3.17
Dockerfile
+ distro specific builder dockerfiles.dockerignore
file updatedTODO / TBD
Notes
Testing
Show what is about to go down:
Build all images locally for arm64 arch (with
--load
and--set "*.platform=linux/arm64"
flags):Same as previous but build only 1 target from
docker-bake.hcl
:Build locally and override image name:
Build and push all images with override image name (needs you logged in to Docker Hub or some other registry):