Small typo #18
Merged
Small typo #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was reading the docs and saw something small. I did try to click the Go library documentation thinking it was the docs on how to use this in a normal Go app, but was surprised it was a link to the Go.dev docs. Any plans, I know it’s early, to document integration with a Go app?
dunglas
approved these changes
Oct 14, 2022
|
Thanks. Regarding the Go lib, the doc isn't rendering as expected on pkg.go.dev, I'll take a look. Here are two examples of how to use the lib in a Go program: https://github.com/dunglas/frankenphp/blob/main/frankenphp_test.go#L424-L437 |
|
@dunglas last time I experienced this it was due to a license on the repo and using the “right” versioning: https://pkg.go.dev/about#adding-a-package |
|
Indeed, this is fixed now! https://pkg.go.dev/github.com/dunglas/frankenphp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reading the docs and saw something small.
I did try to click the Go library documentation thinking it was the docs on how to use this in a normal Go app, but was surprised it was a link to the Go.dev docs. Any plans, I know it’s early, to document integration with a Go app?