Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add a note for TLS with localhost #22

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Conversation

Pierstoval
Copy link
Contributor

It's mostly a note for people that don't know Caddy's TLS system, as I stumbled upon this issue this morning, and forgot that Caddy's localhost vs 127.0.0.1 TLS handling is not the same 😅

Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The certificate will never be trusted by default by the host anyway because the app runs in a container.

@Pierstoval
Copy link
Contributor Author

Indeed, but by using localhost you get a browser warning telling you to "accept the risk", while when using IP addresses or other domain names you end up with an unrecoverable ssl error that prevents you from using the app altogether

@dunglas
Copy link
Owner

dunglas commented Oct 15, 2022

I suggest just adding and accept the self-signed certificate to the existing sentence in the readme. We can add a new doc entry about TLS if necessary but I would like to not "pollute" the readme too much.

@Pierstoval
Copy link
Contributor Author

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants