Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(caddy): php_server simplified directive #235

Merged
merged 13 commits into from
Oct 3, 2023
Merged

feat(caddy): php_server simplified directive #235

merged 13 commits into from
Oct 3, 2023

Conversation

dunglas
Copy link
Owner

@dunglas dunglas commented Sep 29, 2023

Introduce a new simplified php_server directive, which is very similar to the php_fastcgi directive provided by Caddy.

This is now all you need to start a production-grade PHP server:

{
    frankenphp
    order php_server before reverse_proxy
}

localhost {
    encode zstd gzip
    php_server
    file_server
}

Would you mind checking if the code looks good to you and if it follows Caddy's best practices @francislavoie @mholt?

Replaces #92.

Copy link
Contributor

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you know this is just what I always wanted for PHP 😭 and is precisely the reason I didn't originally name the php_fastcgi directive php or php_server -- I knew there had to be a better way to do PHP in the future! 💯 👏

approved

caddy/caddy.go Outdated Show resolved Hide resolved
dunglas and others added 3 commits September 29, 2023 17:36
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
caddy/caddy.go Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
Co-authored-by: Francis Lavoie <lavofr@gmail.com>
@mholt
Copy link
Contributor

mholt commented Sep 30, 2023

Thank you Francis, for being more thorough 😅 (It's been a stressful day here.)

@dunglas dunglas merged commit 2d91a60 into main Oct 3, 2023
29 checks passed
@dunglas dunglas deleted the feat/php_server branch October 3, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants