refactor: faster $_SERVER variables creation #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withinboredom
approved these changes
Nov 15, 2023
| allocServerVariable(&cArr, fc.env, gatewayInterface, "GATEWAY_INTERFACE", "CGI/1.1") | ||
| allocServerVariable(&cArr, fc.env, serverProtocol, "SERVER_PROTOCOL", request.Proto) | ||
| allocServerVariable(&cArr, fc.env, serverSoftware, "SERVER_SOFTWARE", "FrankenPHP") | ||
| allocServerVariable(&cArr, fc.env, httpHost, "HTTP_HOST", request.Host) // added here, since not always part of headers |
There was a problem hiding this comment.
Does request.Host come from the headers, if it is set there? I know many WordPress installs typically set the site name from this variable.
There was a problem hiding this comment.
More or less yes https://pkg.go.dev/net/http#Request.Host
| frankenphp_register_known_variable("REQUEST_URI", SG(request_info).request_uri, track_vars_array,false); | ||
|
|
||
| /* Known variables */ | ||
| frankenphp_register_known_variable("CONTENT_LENGTH", known_variables[0], track_vars_array, true); |
There was a problem hiding this comment.
It might be worth using consts for the indices of known_variables and then reusing them in allocServerVariable() on the Go side. It'd help with maintaining and reviewing, but other than that, wouldn't do anything.
There was a problem hiding this comment.
I'm not sure it will help maintenance to add macros, to be honest, but PR is welcome!
dunglas
force-pushed
the
refactor/populate-env
branch
from
da1e7bf
to
8492aa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes how $_SERVER variables are populated to minimize allocations.
Also, reduce the number of switches between C and Go.
According to the benchmark introduced in #298, this change improves memory usage by 38% compared to
main, and from 78% compared to RC3.Benchmark:
Some string data are still copied from C to Go. I tried to avoid that by using
unsafe.StringData)(but didn't manage to get something that works because it looks not possible to pin pointers returned byunsafe.StringData()