Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to PHP 8.3 #317

Merged
merged 1 commit into from
Nov 29, 2023
Merged

feat: Upgrade to PHP 8.3 #317

merged 1 commit into from
Nov 29, 2023

Conversation

siketyan
Copy link
Contributor

@siketyan siketyan commented Nov 25, 2023

PHP 8.3 was released (https://www.php.net/downloads.php#v8.3.0) so we can now upgrade. This pull request upgrades PHP 8.3-rc to 8.3 stable, and sets 8.3 as the default (dunglas/frankenphp:latest now refer 8.3). Also upgrades to 8.3 in dev builds.

Note that this PR depends on the official base image updates (docker-library/php#1464).

Signed-off-by: Natsuki Ikeguchi <me@s6n.jp>
@siketyan
Copy link
Contributor Author

PHP 8.3 official images are now available.
@dunglas Could you please re-run the workflow to confirm it works when you have time?

@dunglas
Copy link
Owner

dunglas commented Nov 28, 2023

@siketyan done, but it looks like there is a cache issue somewhere. Maybe add --no-cache to the build command for a single run?

@siketyan
Copy link
Contributor Author

All green!
https://github.com/dunglas/frankenphp/actions/runs/7027974512

Retrying with removing --no-cache now...

@siketyan
Copy link
Contributor Author

siketyan commented Nov 29, 2023

@dunglas CI runs got green, ready for review!

@dunglas dunglas merged commit b32e738 into dunglas:main Nov 29, 2023
45 of 54 checks passed
@dunglas
Copy link
Owner

dunglas commented Nov 29, 2023

Thank you!

@siketyan siketyan deleted the feat/php83 branch November 29, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants